Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magento fails on captcha even it not used #30991

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

Magento fails on captcha even it not used #30991

wants to merge 4 commits into from

Conversation

kandy
Copy link
Contributor

@kandy kandy commented Nov 19, 2020 •
edited by m2-assistant bot
Loading

Description (*)

imageftbbox function is only available if PHP is compiled with freetype support (--with-freetype-dir=DIR)
based on https://www.php.net/manual/en/function.imageftbbox.php

Manual testing scenarios (*)

  1. compile php without freetype font support
  2. try to login to magento admin

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Magento fails on captcha even it not used  #31134: Magento fails on captcha even it not used

@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2020

Hi @kandy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@kandy
Copy link
Contributor Author

kandy commented Nov 19, 2020

@magento run all tests

ihor-sviziev
ihor-sviziev requested changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kandy,
Could you provide additional info what issue are you trying to resolve and what are steps to reproduce?

@kandy
Copy link
Contributor Author

kandy commented Nov 20, 2020

@magento run all tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Nov 24, 2020
@gabrieldagama
Copy link
Contributor

Hi @kandy, can you provide more details on this PR? Thanks!

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 2, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 2, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 2, 2020
Open
4 tasks
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: review Award: bug fix labels Dec 7, 2020
@ihor-sviziev
Copy link
Contributor

I see you already update the issue description. Seems like it's clear enough now.
@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests, WebAPI Tests

@ihor-sviziev ihor-sviziev removed the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Dec 8, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8542 has been created to process this Pull Request

@ihor-sviziev ihor-sviziev mentioned this pull request Mar 30, 2021
Closed
16 tasks
@engcom-Delta engcom-Delta self-assigned this Dec 19, 2023
@engcom-Delta engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 29, 2023
@engcom-Dash engcom-Dash self-assigned this Oct 15, 2024
@engcom-Dash
Copy link
Contributor

Hello @kandy,

Thanks for the contributions!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • As per the desciption

Before: ✖️

  • Noticed below error in log file:
    Image CAPTCHA requires FT fonts support [] []

After: ✔️

  • Didn't notice any error and functionality is working as expected.
image

Builds are failed hence moving it to Extended Testing.

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Dash
Copy link
Contributor

The Functional B2B test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30991/b0c48ee35bb4e37f82f7a939528466e1/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/cd3766e0a809bcf1/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30991/78cffe85ecfebcdd0df1f1766792028b/Functional/allure-report-b2b/index.html#categories/5072882f07cb874cae0a44e8084918d0/6a8eea112acd6145/
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

@engcom-Dash engcom-Dash

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Captcha Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Magento fails on captcha even it not used
7 participants
@kandy @gabrieldagama @sidolov @ihor-sviziev @magento-engcom-team @engcom-Dash @engcom-Delta