Incorrect Annotation for `Magento\Framework\App\CacheInterface::load` #31987

bluemwhitew · 2021-02-08T06:29:38Z

Description (*)

Amended an annotation that was causing issues with CI tooling, such as Scrutinizer CI.

Fixed Issues

Fixes Magento\Framework\App\CacheInterface::load annotation is wrong #31450

Related Pull Requests

N/A

Manual Testing Scenarios (*)

N/A

Questions or Comments

N/A

Contribution Checklist (*)

Author has signed the Adobe CLA
Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…nterface::load` - Amending Annotation - Improving Readability

m2-assistant · 2021-02-08T06:29:40Z

Hi @bluemwhitew. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

bluemwhitew · 2021-02-08T07:36:03Z

@magento run Semantic Version Checker

lib/internal/Magento/Framework/App/CacheInterface.php

ihor-sviziev

Could you add php declare strict_types declare(strict_types=1); at the top file?

…nterface::load` - Code Review Feedback/Amends

mrtuvn · 2021-03-10T03:13:49Z

CC: @kandy @paliarush @sivaschenko @vzabaznov May need your guys help for verify

ihor-sviziev · 2021-03-10T07:28:08Z

@magento run all tests

ihor-sviziev · 2021-03-11T08:19:57Z

@magento run Functional Tests EE, Unit Tests

engcom-Charlie · 2022-11-07T05:56:23Z

It seems that bot moved this PR from To Approve to Ready for Testing so moving it back.

engcom-Charlie · 2022-11-07T06:30:20Z

@magento run all tests

magento-automated-testing · 2022-11-07T06:30:24Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-11-07T11:05:06Z

Created new Approval Jira ticket on adobe portal for the SVC test failure. Waiting for the approvals.

Thank you!

bluemwhitew · 2023-02-09T00:18:23Z

Bump.

RaghavendraTirumalasetti · 2023-02-13T10:13:13Z

@magento run all tests

magento-automated-testing · 2023-02-13T10:13:24Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

RaghavendraTirumalasetti · 2023-02-13T14:13:06Z

@magento run WebAPI Tests

magento-automated-testing · 2023-02-13T14:13:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

RaghavendraTirumalasetti · 2023-02-13T14:17:37Z

@magento run Functional Tests B2B

magento-automated-testing · 2023-02-13T14:17:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

RaghavendraTirumalasetti · 2023-02-14T07:17:56Z

Moving this PR to Pending Approval as per this comment.

Thank you!

…nterface

engcom-Echo · 2023-09-11T09:54:31Z

@magento run all tests

magento-automated-testing · 2023-09-11T09:54:36Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-09-11T10:06:26Z

@magento run all tests

magento-automated-testing · 2023-09-11T10:06:34Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento#31450: Incorrect Annotation for `Magento\Framework\App\CacheI…

d168ed2

…nterface::load` - Amending Annotation - Improving Readability

m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Feb 8, 2021

magento-engcom-team added Component: App Release Line: 2.4 labels Feb 8, 2021

m2-community-project bot added the Progress: pending review label Feb 8, 2021

mrtuvn reviewed Feb 23, 2021

View reviewed changes

lib/internal/Magento/Framework/App/CacheInterface.php Show resolved Hide resolved

m2-community-project bot assigned mrtuvn Feb 23, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Feb 23, 2021

ihor-sviziev requested changes Mar 5, 2021

View reviewed changes

m2-community-project bot assigned ihor-sviziev Mar 5, 2021

m2-community-project bot added Progress: needs update and removed Progress: review labels Mar 5, 2021

magento#31450: Incorrect Annotation for `Magento\Framework\App\CacheI…

b4af7fe

…nterface::load` - Code Review Feedback/Amends

bluemwhitew requested review from mrtuvn and ihor-sviziev March 9, 2021 17:50

bluemwhitew added Progress: pending review and removed Progress: needs update labels Mar 9, 2021

mrtuvn removed their assignment Mar 10, 2021

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Mar 10, 2021

ihor-sviziev added the Progress: review label Mar 10, 2021

m2-community-project bot removed the Progress: needs update label Mar 10, 2021

ihor-sviziev approved these changes Mar 11, 2021

View reviewed changes

m2-community-project bot added Progress: to approve and removed Progress: ready for testing labels Nov 7, 2022

m2-community-project bot added Progress: pending approval and removed Progress: to approve labels Nov 7, 2022

m2-community-project bot added Progress: pending review Progress: pending approval and removed Progress: pending approval Progress: pending review labels Dec 14, 2022

m2-community-project bot added Progress: ready for testing and removed Progress: pending approval labels Feb 9, 2023

m2-community-project bot added Progress: pending approval and removed Progress: ready for testing labels Feb 14, 2023

bluemwhitew and others added 2 commits February 17, 2023 05:58

Merge branch '2.4-develop' into 31450_incorrect-annotation-for-cachei…

b5ccf4b

…nterface

Merge branch '2.4-develop' into 31450_incorrect-annotation-for-cachei…

ab66478

…nterface

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incorrect Annotation for `Magento\Framework\App\CacheInterface::load` #31987

Incorrect Annotation for `Magento\Framework\App\CacheInterface::load` #31987

bluemwhitew commented Feb 8, 2021

m2-assistant bot commented Feb 8, 2021

bluemwhitew commented Feb 8, 2021

ihor-sviziev left a comment

mrtuvn commented Mar 10, 2021 •

edited

Loading

ihor-sviziev commented Mar 10, 2021

ihor-sviziev commented Mar 11, 2021

engcom-Charlie commented Nov 7, 2022

engcom-Charlie commented Nov 7, 2022

magento-automated-testing bot commented Nov 7, 2022

engcom-Charlie commented Nov 7, 2022

bluemwhitew commented Feb 9, 2023

RaghavendraTirumalasetti commented Feb 13, 2023

magento-automated-testing bot commented Feb 13, 2023

RaghavendraTirumalasetti commented Feb 13, 2023

magento-automated-testing bot commented Feb 13, 2023

RaghavendraTirumalasetti commented Feb 13, 2023

magento-automated-testing bot commented Feb 13, 2023

RaghavendraTirumalasetti commented Feb 14, 2023

engcom-Echo commented Sep 11, 2023

magento-automated-testing bot commented Sep 11, 2023

engcom-Echo commented Sep 11, 2023

magento-automated-testing bot commented Sep 11, 2023

Incorrect Annotation for Magento\Framework\App\CacheInterface::load #31987

Are you sure you want to change the base?

Incorrect Annotation for Magento\Framework\App\CacheInterface::load #31987

Conversation

bluemwhitew commented Feb 8, 2021

Description (*)

Fixed Issues

Related Pull Requests

Manual Testing Scenarios (*)

Questions or Comments

Contribution Checklist (*)

m2-assistant bot commented Feb 8, 2021

bluemwhitew commented Feb 8, 2021

ihor-sviziev left a comment

Choose a reason for hiding this comment

mrtuvn commented Mar 10, 2021 • edited Loading

ihor-sviziev commented Mar 10, 2021

ihor-sviziev commented Mar 11, 2021

engcom-Charlie commented Nov 7, 2022

engcom-Charlie commented Nov 7, 2022

magento-automated-testing bot commented Nov 7, 2022

engcom-Charlie commented Nov 7, 2022

bluemwhitew commented Feb 9, 2023

RaghavendraTirumalasetti commented Feb 13, 2023

magento-automated-testing bot commented Feb 13, 2023

RaghavendraTirumalasetti commented Feb 13, 2023

magento-automated-testing bot commented Feb 13, 2023

RaghavendraTirumalasetti commented Feb 13, 2023

magento-automated-testing bot commented Feb 13, 2023

RaghavendraTirumalasetti commented Feb 14, 2023

engcom-Echo commented Sep 11, 2023

magento-automated-testing bot commented Sep 11, 2023

engcom-Echo commented Sep 11, 2023

magento-automated-testing bot commented Sep 11, 2023

Incorrect Annotation for `Magento\Framework\App\CacheInterface::load` #31987

Incorrect Annotation for `Magento\Framework\App\CacheInterface::load` #31987

mrtuvn commented Mar 10, 2021 •

edited

Loading