Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #24635: Use of undefined constant GLOB_BRACE in dependency … #31296

Merged
merged 6 commits into from
Apr 28, 2021
Merged

Fix issue #24635: Use of undefined constant GLOB_BRACE in dependency … #31296

merged 6 commits into from
Apr 28, 2021

Conversation

vidyli
Copy link
Contributor

@vidyli vidyli commented Dec 16, 2020 •
edited by engcom-Foxtrot
Loading

@m2-assistant
Copy link

m2-assistant bot commented Dec 16, 2020

Hi @vidyli. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev ihor-sviziev self-assigned this Dec 16, 2020
@ihor-sviziev
Copy link
Contributor

@vidyli could you add to the PR description the following line?

Fixes #24635

@magento run all tests

@m2-community-project m2-community-project bot added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Dec 16, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Static Tests, Unit Tests

@ihor-sviziev
Copy link
Contributor

@vidyli Seems like some changes should be done also on EE or/and B2B repositories.
I see you don't have access to them, so we'll ask someone from the internal team to check it

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests help wanted Progress: needs update labels Dec 16, 2020
@engcom-Golf
Copy link
Contributor

@magento run all tests

1 similar comment
@gabrieldagama
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@engcom-Golf the tests still failing

@engcom-Golf
Copy link
Contributor

engcom-Golf commented Dec 16, 2020 via email •
edited
Loading

@engcom-Golf
Copy link
Contributor

@magento run all tests

ihor-sviziev
ihor-sviziev requested changes Dec 17, 2020
View reviewed changes
composer.lock Outdated
@@ -6316,7 +6318,13 @@
"type": "zip",
"url": "https://api.github.com/repos/allure-framework/allure-codeception/zipball/a69800eeef83007ced9502a3349ff72f5fb6b4e2",
"reference": "a69800eeef83007ced9502a3349ff72f5fb6b4e2",
"shasum": ""
"shasum": "",
"mirrors": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vidyli,
oh... we shouldn't have mirrors section in the composer.lock files.
Could you configure your composer to not use mirrors and run the composer update command?

@ihor-sviziev
Copy link
Contributor

@engcom-Foxtrot, tests still failing :(

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

@ihor-sviziev
Copy link
Contributor

@magento run Integration Tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8698 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@engcom-Oscar, could you take this issue in testing, as it's blocking the #32614?

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Apr 21, 2021 •
edited
Loading

I added label project php8, as we have dependency on this PR there, while it still fixing some another issue.

@sivaschenko
Copy link
Member

@ihor-sviziev removed "Project: PHP8" label to merge this PR together with other PRs from high priority board

@magento-engcom-team magento-engcom-team merged commit 661948c into magento:2.4-develop Apr 28, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 28, 2021

Hi @vidyli, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredden fredden fredden approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@fredden fredden

@ihor-sviziev ihor-sviziev

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of undefined constant GLOB_BRACE in dependency "allure-framework/allure-phpunit"
9 participants
@vidyli @ihor-sviziev @engcom-Golf @gabrieldagama @magento-engcom-team @engcom-Foxtrot @sivaschenko @fredden @sidolov