Release 1.0.0 #30
Merged
Release 1.0.0 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the OS Places geocoder plugin and associated changes.
Unit test for our OS Places geocoder plugin.
Added checks to guard against the use of undefined variables.
The integration test uses previously captured real query responses to run the tests.
Telling composer to install a *dev* dependency during test runs.
php-http/curl-client is a *dev* dependency of the previously added geocoder-php/provider-integration-tests package. This also needs to be explicitly installed. Note that dev dependencies are not fetched during 'composer require' operations. Hence the explicit instruction. As I realize now, this is also why the drupal/core-dev package exist. Perhaps we also need a localgovdrupal/localgov-dev package which will require all our dev dependencies!
…er' into wip/all-pr-2021-10-20
The Ordnance Survey geocoder has moved to its own package: localgovdrupal/localgov_os_places_geocoder_provider.
Replaced the LocalgovAddress Geocoder Model class with the new UprnAddress Model class. UprnAddress is provided by the new localgovdrupal/localgov_os_places_geocoder_provider package. UprnAddress is similar to the older LocalgovAddress class. Also updated some test data to reflect the real output from the OS Places geocoder.
- Dropping unneeded dev dependencies. - Adding new dependency.
OS Places geocoder
…21-10-20 Added date element styling
Added a media query to deal with field sizes on mobile. Make selectors more date field specific.
The LocalgovDrupal\OsPlacesGeocoder\Model\LocationUprnInterface interface got renamed to LocalgovDrupal\OsPlacesGeocoder\Model\AddressUprnInterface during the recent round of great refactoring. But the AddressLookup service here was still using the old interface name. Fixed now.
Fixed usage of renamed class. Added associated tests.
…' into wip/all-pr-2021-10-20
…erface Bug fix: Use renamed PHP interface and class names
Nonnumeric date parts are appearing as *numeric* values alongside form validation error messages. Fixed now. Example: User enters "1A" as a month value. This fails validation, but then appears as "1" in the month input field alongside the validation failure message.
Test dates: - 1D - DD-1-2022 - 1-1-Last year
…dress-button-display-cfg Display config for the "Can't find the address?" button
The checkdate() function in PHP 8.x throws TypeErrors when any non-numeric argument is passed. In previous version of PHP it only logged a warning.
Suppress further PHP warning.
Fix(test run): Adding missing test dependency
Multiple *LocalGov Forms Date* Webform elements in multistep Webforms is causing WSOD (White screen of death). This is because the parent class of the *LocalGov Form Date* element has the `datelist` element name hardcoded into it. So it fails for localgov_forms_date. As a work-around, we override the relevant parent method.
Declaring the localgov_forms_address_lookup form element's corresponding Webform element. This is needed by the localgov_webform_uk_address Webform element.
…-element Fix: Missing Webform Element declaration
…form Fix: Date element in multistep form.
andybroomfield
approved these changes
Dec 19, 2022
Contributor
andybroomfield
left a comment
andybroomfield
left a comment
There was a problem hiding this comment.
Happy to get a beta release out so it can have more wider testing.
Contributor
Author
|
Thanks for the approval. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing the release branch in preparation for the very first beta release. Lots of changes here as we have not made any release of localgov_forms before. Major changes include: