Fix: Date element in multistep form. #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple *LocalGov Forms Date* Webform elements in multistep Webforms is causing WSOD (White screen of death). This is because the parent class of the *LocalGov Form Date* element has the `datelist` element name hardcoded into it. So it fails for localgov_forms_date. As a work-around, we override the relevant parent method.
Member
|
@Adnan-cds is keen to add a test to this before merging. |
andybroomfield
approved these changes
Dec 16, 2022
Contributor
andybroomfield
left a comment
andybroomfield
left a comment
There was a problem hiding this comment.
Tested this with a webform with three localgov date elements on a page in a page wizard element.
Without this PR, I was not able to proceed past the page with the date elements on them once I put a value in them.
With the PR, able to proceed to next page, and the validation rules of the date element also apply.
Contributor
Author
|
Thanks a lot for the detailed test Andy. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple LocalGov Forms Date Webform elements in multistep Webforms is causing WSOD (White screen of death). This is because the parent class of the LocalGov Form Date element has the
datelistelement name hardcoded into it. So it fails for localgov_forms_date. As a work-around, we override the relevant parent method.