Display config for the "Can't find the address?" button #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The localgov_os_places Geocoder plugin has moved to the localgov_geo module. As such, localgov_forms.geocoder.schema.yml has also moved to the localgov_geo module and now lives on as localgov_geo.geocoder.schema.yml.
The manual address entry button labelled "Can't find the address?" is displayed at all times at the moment. This new configuration captures whether to reveal this button from the beginning or only after an address search has happened.
Display the Manual address entry button labelled "Can't find the address?" based on address lookup element configuration.
Adding a new Webform config where the Manual address entry button is displayed *after* an address search. This Webform is then used in a new test to verify the behaviour of the manual address entry button.
...and packages required to use the Localgov OS Places geocoder plugin.
Contributor
Author
|
Taking it to Draft state while we gather feedback from further manual testing. Sorry about the confusion. |
…e-address-button-display-cfg
…e-address-button-display-cfg
Contributor
Author
|
This is Ready for review. We have agreed to add more tickets and pull requests to address the issues arising from the UX review. So this one can go ahead as is. |
ekes
reviewed
May 30, 2022
Member
ekes
left a comment
ekes
left a comment
There was a problem hiding this comment.
I'd say get it merged. Only reason to hold off is if @andybroomfield you think this would be an issue for your usage of this?
| manualButton.removeClass('hidden'); | ||
|
|
||
| // Hide manual entry button if asked for. | ||
| if (typeof settings.centralHub.isManualAddressEntryBtnAlwaysVisible !== 'undefined' && !settings.centralHub.isManualAddressEntryBtnAlwaysVisible) { |
Contributor
There was a problem hiding this comment.
Should probbably remove reference to CentralHub at some point. :-)
andybroomfield
approved these changes
May 30, 2022
Contributor
andybroomfield
left a comment
andybroomfield
left a comment
There was a problem hiding this comment.
Yes this is fine, we can pick up the issue about overriding the label and settings as a later issue.
Contributor
Author
|
Thanks Andy. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9
This change displays the manual address entry button labelled "Can't find the address?" based on address lookup element configuration.
The manual address entry button is displayed at all times at the moment. This new configuration captures whether to reveal this button from the beginning or only after an address search.
By default, the manual address entry button will continue to appear as soon as the LocalGov address lookup element is loaded.
How to test
Screenshot of the new config item follows:
