Date styling #25
Merged
Date styling #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er' into wip/all-pr-2021-10-20
…21-10-20 Added date element styling
Added a media query to deal with field sizes on mobile. Make selectors more date field specific.
…' into wip/all-pr-2021-10-20
Date validation
The checkdate() function in PHP 8.x throws TypeErrors when any non-numeric argument is passed. In previous version of PHP it only logged a warning.
Suppress further PHP warning.
finnlewis
approved these changes
Aug 8, 2022
Member
finnlewis
left a comment
finnlewis
left a comment
There was a problem hiding this comment.
tested locally and seems to work as expected, noting that the errors don't display above the field unless we address that in the theme / twig template.
Contributor
Author
|
Thanks for the approval. Merging... @MattOz-CDS @finnlewis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating #20 with the correct commits. Original author is @MattOz-CDS
Summary of change
We want inline validation error messages to appear above form input fields as per the GDS pattern
https://design-system.service.gov.uk/components/error-summary/
To test