Skip to content

Date validation #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Adnan-cds merged 6 commits into from
Mar 11, 2022
Merged

Date validation #16

Adnan-cds merged 6 commits into from
Mar 11, 2022

Conversation

@Adnan-cds
Copy link
Contributor

@Adnan-cds Adnan-cds commented Mar 11, 2022

Bringing in backend date validation. Frontend date validation already exists in the target branch.

Adnan-cds and others added 6 commits February 25, 2022 16:13
@Adnan-cds
Fix: Test filename!
785e637
@Adnan-cds
Merge pull request #14 from localgovdrupal/fix/3-non-existent-php-int…
5f0885a 
…erface

Bug fix: Use renamed PHP interface and class names
@Adnan-cds
Bug: Date validation.
51dd1c6 
Nonnumeric date parts are appearing as *numeric* values alongside form
validation error messages.  Fixed now.

Example: User enters "1A" as a month value.  This fails validation, but then
appears as "1" in the month input field alongside the validation failure
message.
@Adnan-cds
Test: Invalid date with nonnumeric parts.
c7c31f7 
Test dates:
- 1D
- DD-1-2022
- 1-1-Last year
@Adnan-cds
Fix(test): Coding standards.
1f8f199
@MattOz-CDS
Added HTML5 validation attributes
3b3af2a
@Adnan-cds Adnan-cds merged commit 072b3c3 into wip/all-pr-2021-10-20 Mar 11, 2022
@willguv
Copy link
Member

willguv commented Mar 11, 2022

Hi @Adnan-cds this looks great. I've got a general question about your Forms work - we'd like to try some of this out in Cumbria

Is there a roadmap for this work? How far are you through it please?

Many thanks, Will

@Adnan-cds
Copy link
Contributor Author

Adnan-cds commented Mar 11, 2022

Is there a roadmap for this work? How far are you through it please?

Hi Will,
I am not aware of any roadmap. Rich may know better. Coping @richardaclarke

At the moment we are 1) improving the Date form element code that originated at BHCC. On top of that we have added the 2) Address lookup element which can tap into various address lookup APIs like OpenStreetmap, Google maps, Ordnance survey, etc.

Among the upcoming tasks that I am aware of are:

  • The Address lookup element needs some UX improvement.
  • Editors working on forms have pointed out some issues around conditionally displaying form Submit buttons. This needs resolving.
  • Spam protection is something we have spoken about in one of the recent Merge Monday meetings. This is one of the top priorities.
  • Chris is working on improving the styling of the form elements. I don't know how much of this will eventually make into the localgov_base theme. Chris will know better. I am copying @cjstevens78
  • Matt has integrated forms with Gov Notify. This can either lead to code and/or documentation.

@willguv
Copy link
Member

willguv commented Mar 11, 2022

Cheers @Adnan-cds

Also @richardaclarke, Cumbria devs might be able to help with some of this, as may others

Shall we catch up?

@keelanfh keelanfh mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Adnan-cds @willguv @MattOz-CDS