Bug fix: Use renamed PHP interface and class names #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LocalgovDrupal\OsPlacesGeocoder\Model\LocationUprnInterface interface got renamed to LocalgovDrupal\OsPlacesGeocoder\Model\AddressUprnInterface during the recent round of great refactoring. But the AddressLookup service here was still using the old interface name. Fixed now.
Fixed usage of renamed class. Added associated tests.
Adnan-cds
changed the title
Member
|
Discussing this with @ekes and @Adnan-cds at our Merge Monday meeting. @ekes is happy that if the tests are now passing, we should merge this in. @Adnan-cds points out that the OS API returns UPRN number without leading zeros. This change avoids the 'parseInt' problem of trying to parse an empty string as a number. Leaving it as a string makes sense. For the record:
In summary, we're happy to approve this pull request. |
finnlewis
approved these changes
Feb 28, 2022
Contributor
Author
|
Thanks. I am merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LocalgovDrupal\OsPlacesGeocoder\Model\LocationUprnInterface interface has been renamed to LocalgovDrupal\OsPlacesGeocoder\Model\AddressUprnInterface during recent refactoring. But the AddressLookup service here was still using the old interface name.
Similarly, the LocalgovDrupal\OsPlacesGeocoder\Model\UprnAddress class has been renamed to LocalgovDrupal\OsPlacesGeocoder\Model\OsPlacesAddress. The mock Geocoder used for testing was using the old class.
These were not picked up by the test earlier because I missed the "Test" suffix from the test classname and as a result the test wasn't running at all! All fixed now :)
Also some coding standards fixes.