Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert migrate maintainers to members for kubernetes-incubator #591

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Mar 11, 2019

Peribolos fails with a 403 when it tries to update memberships for certain teams in kubernetes-incubator. This temporarily unblocks peribolos so other changes can be synced.

{"client":"github","component":"peribolos","level":"info","msg":"UpdateTeamMembership(2113629, euank, false)","time":"2019-03-11T03:17:04Z"}
{"component":"peribolos","error":"is the account using at least one of the following oauth scopes?: admin:org, repo","level":"warning","msg":"UpdateTeamMembership(2113629, euank, false) failed","time":"2019-03-11T03:17:07Z"}
{"component":"peribolos","level":"fatal","msg":"Configuration failed: failed to configure kubernetes-incubator teams: failed to update maintainers-rktlet members: 1 errors: [is the account using at least one of the following oauth scopes?: admin:org, repo]","time":"2019-03-11T03:17:07Z"}

The relevant diff from #566: https://github.com/kubernetes/org/pull/566/files#diff-3b95bdd66ee80ec3ebbed25503db3376

Note: I am only reverting the change for k-incubator here because teams in other orgs have been synced (some teams in kuberntes-incubator have also been synced but it should be ok to have that change reverted). I'm also not completely sure that this will fix the error, but it seems the best solution to me right now. I have created kubernetes/test-infra#11720 to help debug better in the future.

For some more context, the relevant slack discussion: https://kubernetes.slack.com/archives/C1TU9EB9S/p1552055216157000

/hold
Holding for lgtm from @spiffxp or @fejta

/cc @spiffxp @mrbobbytables @justaugustus @rlenferink @idealhack
/assign @spiffxp @fejta

Peribolos fails with a 403 when it tries to update memberships for
certain teams in k-incubator. This temporarily unblocks Peribolos
so other changes can be synced.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member

spiffxp commented Mar 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2019
@nikhita
Copy link
Member Author

nikhita commented Mar 11, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 25767f0 into kubernetes:master Mar 11, 2019
@nikhita nikhita deleted the revert-migrate-maintainers-for-k-incubator branch March 11, 2019 14:23
@nikhita
Copy link
Member Author

nikhita commented Mar 11, 2019

Also, a quick note that this doesn't occur due to rate limiting problems. We check for the scopes after checking for exceeding the rate limiting or hitting abuse detection.

nikhita added a commit to nikhita/org that referenced this pull request Mar 11, 2019
…-maintainers-for-k-incubator"

This reverts commit 25767f0, reversing
changes made to 43666b8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants