-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert migrate maintainers to members for kubernetes-incubator #591
Revert migrate maintainers to members for kubernetes-incubator #591
Conversation
Peribolos fails with a 403 when it tries to update memberships for certain teams in k-incubator. This temporarily unblocks Peribolos so other changes can be synced.
This reverts commit b374aa4.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold cancel |
Also, a quick note that this doesn't occur due to rate limiting problems. We check for the scopes after checking for exceeding the rate limiting or hitting abuse detection. |
Peribolos fails with a 403 when it tries to update memberships for certain teams in kubernetes-incubator. This temporarily unblocks peribolos so other changes can be synced.
The relevant diff from #566: https://github.com/kubernetes/org/pull/566/files#diff-3b95bdd66ee80ec3ebbed25503db3376
Note: I am only reverting the change for k-incubator here because teams in other orgs have been synced (some teams in kuberntes-incubator have also been synced but it should be ok to have that change reverted). I'm also not completely sure that this will fix the error, but it seems the best solution to me right now. I have created kubernetes/test-infra#11720 to help debug better in the future.
For some more context, the relevant slack discussion: https://kubernetes.slack.com/archives/C1TU9EB9S/p1552055216157000
/hold
Holding for lgtm from @spiffxp or @fejta
/cc @spiffxp @mrbobbytables @justaugustus @rlenferink @idealhack
/assign @spiffxp @fejta