Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce non-admins shouldn't be team maintainers #849

Merged
merged 3 commits into from
May 29, 2019
Merged

Enforce non-admins shouldn't be team maintainers #849

merged 3 commits into from
May 29, 2019

Conversation

cblecker
Copy link
Member

This is a manual revert of #591, and a retake of #592

If this looks good, I'll do a manual peribolos run to fix any weird errors that arise.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 29, 2019
@cblecker cblecker mentioned this pull request May 29, 2019
Closed
@cblecker
Copy link
Member Author

/assign @nikhita

@cblecker cblecker mentioned this pull request May 29, 2019
Closed
nikhita
nikhita approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold
to make sure the manual run is green

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member Author

/hold cancel

Let’s let the auto run go, and I’ll inspect the results.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 84fc997 into kubernetes:master May 29, 2019
@nikhita
Copy link
Member

nikhita commented May 29, 2019

https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/post-org-peribolos/1133752154507448320 😞

@cblecker cblecker deleted the reorder branch May 29, 2019 16:40
@rlenferink
Copy link
Member

It looks like peribolos is returning the same error message as described in #591

@cblecker
Copy link
Member Author

I ran it locally with my token, and didn't encounter errors. Very curious.

@nikhita
Copy link
Member

nikhita commented May 29, 2019

I ran it locally with my token, and didn't encounter errors.

Now that the actual teams reflect the config with this run, hopefully we don't see any errors in the ci... 🤞

@cblecker
Copy link
Member Author

Yeah, that's my hope too. Still unsure what the error was. The bot looks like it has the right permissions and such. I'm asking test-infra to re-run the CI job.

@nikhita
Copy link
Member

nikhita commented May 29, 2019

I'm asking test-infra to re-run the CI job.

The latest CI run was green! 🎉

https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-org-peribolos/1133790031064862720

@hoegaarden hoegaarden mentioned this pull request Jun 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@calebamiles calebamiles Awaiting requested review from calebamiles

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cblecker @k8s-ci-robot @nikhita @rlenferink