Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert GitHub team maintainers to members #563

Closed
spiffxp opened this issue Mar 5, 2019 · 12 comments
Closed

Convert GitHub team maintainers to members #563

spiffxp opened this issue Mar 5, 2019 · 12 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@spiffxp
Copy link
Member

spiffxp commented Mar 5, 2019

Now that we automate the management of GitHub teams (#336), it is confusing when people try to use GitHub's UI to manually manage teams, only to have their changes reverted (eg: #559)

While we wait for docs (kubernetes/community#3102) I believe we should move everyone to being a regular team member, and encourage use of PR's against this repo for GitHub team management

That said, one fun little wrinkle I discovered in #522 is that GitHub Owners need to remain team maintainers

/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 5, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Mar 5, 2019

Notified kubernetes-dev@

@nikhita
Copy link
Member

nikhita commented Mar 5, 2019

I'll update the docs and config.

/assign

@rlenferink
Copy link
Member

rlenferink commented Mar 5, 2019

I'll update the docs and config.

/assign

@nikhita While we're at it with PR #546, should I update the other sig-docs teams as well to 'convert' maintainers to members?

@nikhita
Copy link
Member

nikhita commented Mar 5, 2019

@nikhita While we're at it with PR #546, should I update the other sig-docs teams as well to 'convert' maintainers to members?

Sure, that would be good. :)

@nikhita
Copy link
Member

nikhita commented Mar 5, 2019

Created #566 for the config part.

I'll add the docs later this week.

@nikhita
Copy link
Member

nikhita commented Mar 6, 2019

Created kubernetes/community#3368 for the docs.

@nikhita
Copy link
Member

nikhita commented Mar 8, 2019

The config part has now merged: #566. All existing (non-admin) team maintainers have been converted to members and a test has been added to check that non-admins are not listed as maintainers.

Also notified k-dev that this is done: https://groups.google.com/d/msg/kubernetes-dev/WtvHtt2lR1w/TMiaTjESCAAJ

@nikhita
Copy link
Member

nikhita commented Mar 19, 2019

/sig contributor-experience
/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Mar 19, 2019
@cblecker
Copy link
Member

Take two: #849

@justaugustus
Copy link
Member

This is now complete, right?

@nikhita
Copy link
Member

nikhita commented May 30, 2019

Yes! 🎉

/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closing this issue.

In response to this:

Yes! 🎉

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Development

No branches or pull requests

6 participants