Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /me to the patch release and release managers team #927

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Add /me to the patch release and release managers team #927

merged 1 commit into from
Jun 19, 2019

Conversation

hoegaarden
Copy link
Contributor

  • I was removed from patch-release-team in this PR, I am not sure why. Re-adding myself again.
  • I think I also need to be on release-managers to be able to actually cut a patch.

If there are good reasons why I have been removed in the first place, please let me know.

/cc @kubernetes/patch-release-team
/cc @kubernetes/release-managers
/cc @cblecker

@k8s-ci-robot
Copy link
Contributor

Welcome @hoegaarden!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 19, 2019
@hoegaarden
Copy link
Contributor Author

/assign justaugustus

@cblecker
Copy link
Member

You were removed as only active branch managers or patch release managers should be in these teams. According to the docs in https://git.k8s.io/sig-release, I see you were the 1.14 branch manager, but that release has already shipped.

@justaugustus
Copy link
Member

justaugustus commented Jun 19, 2019

@hoegaarden -- I had discussed with @cblecker (via DM) that this change should've been made separately from the changes in that PR, but I should've noted that publicly as well.

Christoph --
Approving this as Hannes will be a part of the official roster moving forward: https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md#contact

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hoegaarden, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit e9fd6f8 into kubernetes:master Jun 19, 2019
@cblecker
Copy link
Member

@justaugustus Thanks for the updated docs!

I have two asks:

  • When the 1.15 dust settles, would you mind sending out a wider notice of this change? I don't remember seeing one go out to the whole project.
  • Can you update the docs to note that if this team changes, you should explicitly reach out to the GitHub admin team? In addition to these teams, there's also things like k-security access that needs to be granted/updated.

@justaugustus
Copy link
Member

@cblecker -- For sure. I'm actually writing a doc on Release Managers team structure right now.
Stay tuned! :)

@cblecker
Copy link
Member

@justaugustus You're the best!

@justaugustus
Copy link
Member

@cblecker -- No, no, you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants