Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate team maintainers to members #566

Merged
merged 3 commits into from
Mar 7, 2019
Merged

Migrate team maintainers to members #566

merged 3 commits into from
Mar 7, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Mar 5, 2019

Fixes the config part of #563. Because of how the GH API works, note that org admins still need to be in the maintainers list.

/hold
I wrote some quick and hacky go code to generate this...which meant that the comments next to names got lost (eg in milestone-maintainers) with the generation. Still need to fix that but wanted to get the PR out first.

/cc @spiffxp @idealhack @rlenferink

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider ug/big-data Categorizes an issue or PR as relevant to ug-big-data. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. area/provider/gcp Issues or PRs related to gcp provider sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. sig/network Categorizes an issue or PR as relevant to SIG Network. area/provider/openstack Issues or PRs related to openstack provider sig/pm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 5, 2019
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 5, 2019
@nikhita nikhita mentioned this pull request Mar 6, 2019
Merged
@nikhita nikhita force-pushed the migrate-maintainers-to-members branch from 5ba63c6 to 0144481 Compare March 6, 2019 12:25
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 6, 2019
@nikhita
Copy link
Member Author

nikhita commented Mar 6, 2019

I have added back the comments next to names so this should be good to go. I have also created the docs PR for this kubernetes/community#3368.

But I'll leave it to @spiffxp to cancel the hold, in case we want to wait for the docs PR to merge first (I'm ok with either PR merging first).

idealhack
idealhack approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@idealhack idealhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idealhack, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member

spiffxp commented Mar 6, 2019

needs rebase

spiffxp
spiffxp reviewed Mar 6, 2019
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
just needs a rebase

config/kubernetes-sigs/sig-api-machinery/teams.yaml
privacy: closed
yaml-admins:
description: ""
maintainers:
- deads2k
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ consistent formatting

@nikhita nikhita force-pushed the migrate-maintainers-to-members branch from 0144481 to 81a166b Compare March 7, 2019 05:02
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@nikhita
Copy link
Member Author

nikhita commented Mar 7, 2019

Rebased.

@nikhita nikhita force-pushed the migrate-maintainers-to-members branch from 81a166b to 8ec77fd Compare March 7, 2019 05:10
@rlenferink
Copy link
Member

/lgtm
/hold cancel

Cancelling hold as @spiffxp already added his /lgtm

Thanks for this @nikhita 🎉

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit f7f41db into kubernetes:master Mar 7, 2019
@nikhita nikhita deleted the migrate-maintainers-to-members branch March 8, 2019 05:09
@nikhita
Copy link
Member Author

nikhita commented Mar 8, 2019

Notified k-dev that this is done: https://groups.google.com/d/msg/kubernetes-dev/WtvHtt2lR1w/TMiaTjESCAAJ.

@nikhita nikhita mentioned this pull request Mar 11, 2019
Merged
@rlenferink rlenferink mentioned this pull request Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlenferink rlenferink rlenferink left review comments

@spiffxp spiffxp spiffxp left review comments

@idealhack idealhack idealhack approved these changes

Assignees

@spiffxp spiffxp

@idealhack idealhack

@rlenferink rlenferink

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. ug/big-data Categorizes an issue or PR as relevant to ug-big-data. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikhita @k8s-ci-robot @spiffxp @rlenferink @idealhack