List currently authorized scopes on 403 #11720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot be certain that the 403 error is caused by insufficient permissions, so while displaying which scopes should be used also display which scopes are in use.
k8s-ci-robot
added
cncf-cla: yes
nikhita
commented
Mar 11, 2019
| err = fmt.Errorf("is the account using at least one of the following oauth scopes?: %s", oauthScopes) | ||
| authorizedScopes := resp.Header.Get("X-OAuth-Scopes") | ||
| if authorizedScopes == "" { | ||
| authorizedScopes = "no" |
There was a problem hiding this comment.
Personally, I don't like setting the authorizedScopes to "no" here...but I can't figure out how to make the message pretty without it. 🤔
|
Seems fine for me /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3dd1156bd949bad3d3c3862e872d8e7283cd629a
|
|
/approve Thanks @nikhita |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot be certain that the 403 error is caused by insufficient permissions, so while displaying which scopes should be used also display which scopes are in use currently so that it's easier to debug.
Ref: #3647 (comment)
Context for this change: peribolos currently fails with:
I haven't really figured out the root cause of the error yet but it seemed weird that the token didn't have the org admin scope....it'd be useful to also list the oauth scopes that the token currently uses so that it's easier to debug in the future.
/cc @stevekuznetsov @cjwagner @fejta @spiffxp