Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add krmayankk to kubernetes-milestone-maintainers team #585

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

krmayankk
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2019
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Mar 8, 2019
@nikhita
Copy link
Member

nikhita commented Mar 8, 2019

/assign @justaugustus

@@ -10,6 +10,7 @@ teams:
- idvoretskyi # PM
- nikhita # ContribEx
- spiffxp # 1.14 RT Lead / Testing
- krmayankk # 1.14 RT Bug Triage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this list needs to be sorted :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and you'll need to add in the members list

(only org admins can be in the maintainers list)

@justaugustus
Copy link
Member

@krmayankk -- there is a maintainers listing for each team across all org configs in this repo, so this is a little confusing to a passerby.

Could you amend to the commit msg and issue title to something like Add krmayankk to kubernetes-milestone-maintainers team?

@krmayankk krmayankk changed the title add myself to maintainers Add krmayankk to kubernetes-milestone-maintainers team Mar 8, 2019
@krmayankk
Copy link
Author

@justaugustus done

@justaugustus
Copy link
Member

@krmayankk please amend the commit message too

@krmayankk
Copy link
Author

@justaugustus done

@justaugustus
Copy link
Member

Thanks @krmayankk!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, krmayankk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 43666b8 into kubernetes:master Mar 11, 2019
@krmayankk krmayankk deleted the maintain branch March 11, 2019 07:05
@krmayankk
Copy link
Author

@justaugustus did i add it to the wrong place, my powers dont work yet :-( kubernetes/website#12297

@justaugustus
Copy link
Member

@krmayankk -- I believe there are currently some issues with peribolos (the tool the leverages these configs), so it's possible that the periodic GH org sync was not successful.

@nikhita / @spiffxp / @fejta might be able to provide more details for you.

@nikhita
Copy link
Member

nikhita commented Mar 11, 2019

Yeah, peribolos is currently red right now...created #591 to help fix it.

@nikhita
Copy link
Member

nikhita commented Mar 11, 2019

@krmayankk you should have powers to apply the milestone right now! 🎉 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants