Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/kubernetes: sig-k8s-infra team updates #3008

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 24, 2021

Related:

This is mostly to exercise jobs to confirm they all still work

k8s.io-admins ~= has root approval, there isn't much use for a
distinction of "has write access but not root approval"
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 24, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 24, 2021

/cc @dims @ameukam

@mrbobbytables
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 509af98 into kubernetes:main Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
@spiffxp spiffxp deleted the sig-k8s-infra-updates branch September 24, 2021 22:30
@spiffxp
Copy link
Member Author

spiffxp commented Sep 24, 2021

Looks like I didn't get the github token setup quite right

/home/prow/go/src/github.com/kubernetes/org/_output/bin/peribolos \
	--config-path /home/prow/go/src/github.com/kubernetes/org/_output/gen-config.yaml \
	--fix-org \
	--fix-org-members \
	--fix-teams \
	--fix-team-members \
	 \
	 --required-admins=cblecker  --required-admins=fejta  --required-admins=idvoretskyi  --required-admins=mrbobbytables  --required-admins=nikhita  --required-admins=spiffxp \
	deploy

@spiffxp
Copy link
Member Author

spiffxp commented Sep 24, 2021

Fix in #3010

@spiffxp
Copy link
Member Author

spiffxp commented Sep 24, 2021

$ WHAT=foo make deploy -- --github-token-path=foo/bar/baz
go test ./... --config=/Users/spiffxp/w/kubernetes/org/_output/gen-config.yaml
?   	k8s.io/org/cmd/merge	[no test files]
ok  	k8s.io/org/config	0.235s
/Users/spiffxp/w/kubernetes/org/_output/bin/peribolos \
		--config-path /Users/spiffxp/w/kubernetes/org/_output/gen-config.yaml \
		--fix-org \
		--fix-org-members \
		--fix-teams \
		--fix-team-members \
		 \
		 --required-admins=cblecker  --required-admins=fejta  --required-admins=idvoretskyi  --required-admins=mrbobbytables  --required-admins=nikhita  --required-admins=spiffxp \
		--github-token-path=foo/bar/baz

@spiffxp spiffxp mentioned this pull request Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants