Skip to content

config/jobs: use make for kubernetes/org - #23745

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
spiffxp:use-make-for-org
Sep 24, 2021
Merged

config/jobs: use make for kubernetes/org#23745
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
spiffxp:use-make-for-org

Conversation

@spiffxp

@spiffxp spiffxp commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Related:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2021
@k8s-ci-robot

k8s-ci-robot commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 24, 2021
@spiffxp

spiffxp commented Sep 24, 2021

Copy link
Copy Markdown
Contributor Author

/hold
Can't merge until kubernetes/org#3007 has merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2021
@spiffxp

spiffxp commented Sep 24, 2021

Copy link
Copy Markdown
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2021
@dims

dims commented Sep 24, 2021

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2021
@k8s-ci-robot
k8s-ci-robot merged commit 81584c8 into kubernetes:master Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
@spiffxp
spiffxp deleted the use-make-for-org branch September 24, 2021 22:07
@k8s-ci-robot

k8s-ci-robot commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-org-jobs.yaml using file config/jobs/kubernetes/org/kubernetes-org-jobs.yaml
  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml
Details

In response to this:

Related:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 24, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chases2 chases2 Awaiting requested review from chases2
@idvoretskyi idvoretskyi Awaiting requested review from idvoretskyi

Assignees

@dims dims

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.23

Development

Successfully merging this pull request may close these issues.

3 participants

@spiffxp @k8s-ci-robot @dims