use make #3007
Merged
use make #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the following human-facing targets: - merge: builds and installs the merge binary - config: creates a merged config using the merge binary - test: tests the merged config using go test - peribolos: clones a local copy of kubernetes/test-infra and installs the peribolos binary - deploy: runs periobolos to deploy the merged config if tests pass - clean: remove all intermediary configs and binaries Overrideable env vars: - GITHUB_TOKEN_PATH: value for --github-token-path passed to peribolos - TEST_INFRA_PATH: set to location of a pre-existing clone of kubernetes/test-infra to avoid cloning a temporary copy One way this differs from bazel is that we're not necessarily getting the latest version of test-infra each time we run `make deploy` but I don't foresee peribolos changing that frequently, and a `make clean` is enough to get us back to "latest" state.
The verify-all.sh script ends up calling //hack:verify-all as defined in kubernetes/repo-infra. Two of these checks are bazel-specific and can be removed / ignored for porting: - verify-bazel - verify-deps The other two make sense without bazel, so copy them over: - verify-gofmt.sh (and update-gofmt) - verify-boilerplate.sh Then add a hack/verify.sh script (copied from kubernetes/k8s.io) that calls all verify scripts (excluding verify-all.sh, to allow the bazel-based tests to still run/pass) Then add a verify target to the Makefile
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/github-management
spiffxp
commented
Sep 24, 2021
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
A note here: I didn't make any of these edits myself. I merely downloaded the latest copy of the script from kubernetes/repo-infra
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
cblecker
approved these changes
Sep 24, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced Sep 24, 2021
Merged
This was referenced Sep 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I grew tired of recompiling protobuf to see if our YAML-based config was sorted
Adds the following human-facing targets:
merge: builds and installs the merge binaryconfig: creates a merged config using the merge binarytest: tests the merged config using go testverify: runs hack/verify.shperibolos: clones a local copy of kubernetes/test-infra and installsthe peribolos binary
deploy: runs periobolos to deploy the merged config if tests passclean: remove all intermediary configs and binariesOverrideable env vars:
GITHUB_TOKEN_PATH: value for--github-token-pathpassed toperibolosTEST_INFRA_PATH: set to location of a pre-existing clone ofkubernetes/test-infra to avoid cloning a temporary copy
One way this differs from bazel is that we're not necessarily getting
the latest version of test-infra each time we run
make deploybut Idon't foresee peribolos changing that frequently, and a
make cleanisenough to get us back to "latest" state.