Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bazel-related files #3009

Merged
merged 2 commits into from
Sep 27, 2021
Merged

remove bazel-related files #3009

merged 2 commits into from
Sep 27, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 24, 2021

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 24, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 24, 2021

/cc @mrbobbytables @cblecker

@spiffxp
Copy link
Member Author

spiffxp commented Sep 24, 2021

/hold
Not yet

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 27, 2021

The reason I held is that make is not well suited to plumbing through arbitrary flags. So the postsubmits were dropping the duplicate --github-endpoint flags, resulting in peribolos not using ghproxy.

I gave up trying to use make as the entrypoint for all CI jobs:

Currently watching the pot boil on https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-org-peribolos/1442502192983445504 to confirm ghproxy is being used again

@spiffxp
Copy link
Member Author

spiffxp commented Sep 27, 2021

/hold cancel
Yes, it's being used again, we're good to remove bazel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2021
@mrbobbytables
Copy link
Member

/lgtm
/pony party

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2021
@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: pony image

In response to this:

/lgtm
/pony party

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 3270794 into kubernetes:main Sep 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 27, 2021
@spiffxp spiffxp deleted the rm-bazel branch September 27, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants