Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: fix make deploy #3010

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 24, 2021

Related:

Trying to avoid changing the job config args, which are passed in as --foo=bar. This doesn't work with the approach taken in kubernetes/k8s.io to pass flags through to a make target. So use a different approach.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 24, 2021

/cc @mrbobbytables @cblecker

@mrbobbytables
Copy link
Member

/lgtm

1 similar comment
@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 726f425 into kubernetes:main Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
@spiffxp spiffxp deleted the fix-make-deploy branch September 24, 2021 23:09
@spiffxp
Copy link
Member Author

spiffxp commented Sep 25, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-org-peribolos/1441540041988902912 is still running, which is way way longer than usual

/home/prow/go/src/github.com/kubernetes/org/_output/bin/peribolos \
	--config-path /home/prow/go/src/github.com/kubernetes/org/_output/gen-config.yaml \
	--fix-org \
	--fix-org-members \
	--fix-teams \
	--fix-team-members \
	 \
	 --required-admins=cblecker  --required-admins=fejta  --required-admins=idvoretskyi  --required-admins=mrbobbytables  --required-admins=nikhita  --required-admins=spiffxp \
	--tokens=1200 --github-token-path=/etc/github-token/oauth --github-endpoint=https://api.github.com --confirm

Turns out the hack to pass flags doesn't quite work: two --github-endpoint flags enter, one flag leaves. And unfortunately it's not the one pointing to the ghproxy endpoint. So the job is getting super throttled on token usage.

Much as I wanted to do this cleanly without changing job configs, I'm going to need to: add a proper script that can be called with flags, and then update jobs to use that script.

We're not broken, but we're slowed to a crawl. I will put up the PRs to fix forward but am totally open to rolling back if that's what we'd prefer to do

@spiffxp
Copy link
Member Author

spiffxp commented Sep 25, 2021

OK it turns out passing --foo bar --foo baz will allow both flags though, so I'm just going to change the job config and call it for the week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants