-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: fix make deploy #3010
make: fix make deploy #3010
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
1 similar comment
/lgtm |
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-org-peribolos/1441540041988902912 is still running, which is way way longer than usual
Turns out the hack to pass flags doesn't quite work: two Much as I wanted to do this cleanly without changing job configs, I'm going to need to: add a proper script that can be called with flags, and then update jobs to use that script. We're not broken, but we're slowed to a crawl. I will put up the PRs to fix forward but am totally open to rolling back if that's what we'd prefer to do |
OK it turns out passing |
Related:
Trying to avoid changing the job config args, which are passed in as
--foo=bar
. This doesn't work with the approach taken in kubernetes/k8s.io to pass flags through to a make target. So use a different approach.