Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull from remote master #3

Merged
merged 35 commits into from
May 6, 2020
Merged

pull from remote master #3

merged 35 commits into from
May 6, 2020

Commits on Feb 28, 2019

  1. Configuration menu
    Copy the full SHA
    2ef8d84 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. Configuration menu
    Copy the full SHA
    7742615 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2019

  1. Stop invoking gosimple tool as it's deprecated. (#466)

    Also stop supporting Go 1.10 as Go 1.12 is out.
    aalexand authored and nolanmar511 committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    9daae4f View commit details
    Browse the repository at this point in the history
  2. Add -update flag that can be used to update golden files. (#467)

    This is similar to such flag in driver_test.go and dotgraph_test.go.
    
    I had this change locally for some time, would like to check this in.
    aalexand authored and nolanmar511 committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    f8f10df View commit details
    Browse the repository at this point in the history

Commits on May 2, 2019

  1. Configuration menu
    Copy the full SHA
    8358a97 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. Add flamegraph to list of dynamic search links (#471)

    This adds flamegraph to the list of dynamic search links so that query parameters are retained when navigating to/from the flamegraph view.
    timpalpant authored and nolanmar511 committed May 15, 2019
    Configuration menu
    Copy the full SHA
    54271f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. Configuration menu
    Copy the full SHA
    4e22ea4 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Fix keypress focus (#478)

    timpalpant authored and aalexand committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    34ac40c View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2019

  1. internal: fix typos (#482)

    ainar-g authored and aalexand committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    236ed25 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. webhtml: fix search input svg icon (#484)

    narqo authored and aalexand committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    6ce0274 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Configuration menu
    Copy the full SHA
    35da2c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. Configuration menu
    Copy the full SHA
    2e3a5de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5260658 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. webhtml: reenable sort option for flamegraphs (#491)

    This sorts flamegraph elements lexographiaclly such that two similar
    profiles can be compared side-by-side to eyeball differences in
    flamegraph profile shapes and sizes.
    bbrks authored and aalexand committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    a8b9f9d View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. Configuration menu
    Copy the full SHA
    5e96527 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. Configuration menu
    Copy the full SHA
    73b556c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27840ff View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2019

  1. Add go.mod to the repository (#502)

    * Add go.mod/go.sum
    
    * travis: update to test in modules mode and with go1.13
    
    Remove go1.11 setup
    
    * fix appveyor config
    
    AppVeyor sets the latest go stack in C:\go and that is GOROOT.
    Cloning this repo under C:\go\src\.. directory confused go build
    (as discussed in golang/go#34657). The fix in go is not yet
    released. Thus this commit changes GOPATH to c:\gopath and clones
    the repo under the directory.
    
    Also, this commit removes the go get commands intended to pull in
    dependencies. In modules mode, `go build` pulls in the required
    dependencies.
    hyangah authored and aalexand committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    f9b734f View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. Apply the --divide_by option to the profile before saving it. (#504)

    This allows averaging profiles by using:
    pprof -proto output --divide_by <n> profile1.pb.gz ... profilen.pb.gz
    rauls5382 authored and aalexand committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    d4f498a View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Make tag filter of the form -tagfilter=foo=1 work. (#509)

    Tag filters like `-tagfilter=foo=1` currently cannot be used to filter
    by a unitless numeric tag as the tag filter regular expression expects
    the unit part to be always present.  They can be made working by using
    `-tagfilter=foo=1unit` instead, but that's weird syntax. So fix this by
    merely making the unit part optional.
    
    I was wondering if this simple fix could have any unintended effects but
    as far as I can tell from testing it does not.
    aalexand authored Feb 10, 2020
    Configuration menu
    Copy the full SHA
    2ed0793 View commit details
    Browse the repository at this point in the history
  2. Rename test data files to be consistently lowercase. (#506)

    Co-authored-by: Maggie Nolan <nolanmar@google.com>
    aalexand and nolanmar511 authored Feb 10, 2020
    Configuration menu
    Copy the full SHA
    2827a3c View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. Configuration menu
    Copy the full SHA
    f11f1df View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Configuration menu
    Copy the full SHA
    d9cc468 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. profile: avoid string(int) conversion (#513)

    As per the vet check being introduced in 1.15
    (golang/go#32479), conversions of the form
    string(int) are flagged by go vet. The suggested fix is to instead use
    string(rune).
    
    Additionally, since google/pprof is vendored into the go tree, we avoid
    test failures from vet flagging this dependency (see
    CL https://go-review.googlesource.com/c/go/+/220977).
    smasher164 authored Feb 26, 2020
    Configuration menu
    Copy the full SHA
    4ac0da8 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. profile: change error message to print string representation of wire …

    …type (#514)
    
    The proto write type code stored in buffer stores unprintable values
    (e.g. 2 when unmarshalling). The desired output when printing an error
    message is the string representation of the integer (i.e. strconv.Itoa),
    instead of the current behavior string(int) or string(rune), which
    return the utf8 literal corresponding to the integer.
    
    As pointed out by @ianlancetaylor in
    4ac0da8#commitcomment-37524728, commit
    4ac0da8 preserves the previous incorrect behavior to pass a vet check,
    whereas this change prints the desired output.
    
    Updates golang/go#32479.
    smasher164 authored Feb 29, 2020
    Configuration menu
    Copy the full SHA
    1ebb73c View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. webhtml: make top table header sticky (#518)

    This keeps the column names visible when scrolling down, which comes in
    handy when there are many entries.
    bamarni authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    7d83b28 View commit details
    Browse the repository at this point in the history
  2. profile.CheckValid should return an error if location has a line with…

    … empty function (#517)
    
    * Check if location has a line with empty function
    
    * Include context in the error message that will help triage the error
    Labutin authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    d6d2dc1 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Support Intel syntax in the assembly reports (#520)

    Add support for output assembly in Intel Syntax.
    wyk9787 authored Apr 13, 2020
    Configuration menu
    Copy the full SHA
    b1a9688 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Provide more helpful error message and require input for every non-bo…

    …ol option. (#519)
    
    Provide more helpful error message and require input for every non-bool option.
    wyk9787 authored Apr 17, 2020
    Configuration menu
    Copy the full SHA
    c6e0a84 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Remove the "seconds" parameter to fix tests. (#527)

    * Remove seconds parameter
    
    * Remove anoter seconds parameter
    wyk9787 authored Apr 24, 2020
    Configuration menu
    Copy the full SHA
    4c71eee View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2020

  1. cli: add 'q' as an alias for 'quit' (#525)

    Fixes #524
    
    Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
    prattmic and aalexand authored Apr 25, 2020
    Configuration menu
    Copy the full SHA
    dfef78b View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Configuration menu
    Copy the full SHA
    8f1c0db View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Add callgraph examples to README.md (#528)

    Add callgraph examples to README.md
    
    Co-authored-by: Maggie Nolan <nolanmar@google.com>
    Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
    3 people authored Apr 29, 2020
    Configuration menu
    Copy the full SHA
    e11b803 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Configuration menu
    Copy the full SHA
    fc25d7d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Update README to reflect what green nodes/edges mean. (#531)

    * Update the README.md
    
    * Update the README.md
    
    * Update the README.md
    
    * Update the README.md
    
    * Update the README.md
    wyk9787 authored May 4, 2020
    Configuration menu
    Copy the full SHA
    160c429 View commit details
    Browse the repository at this point in the history