Skip to content

cli: add 'q' as an alias for 'quit' #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2020
Merged

cli: add 'q' as an alias for 'quit' #525

merged 2 commits into from
Apr 25, 2020

Conversation

prattmic
Copy link
Member

Fixes #524

@prattmic
Copy link
Member Author

prattmic commented Apr 21, 2020

Failures look like flakes, or at least not related?

=== RUN   TestHTTPSInsecure
    TestHTTPSInsecure: proftest.go:125: unexpected error: https+insecure://127.0.0.1:57468/debug/pprof/goroutine: server response: 400 Bad Request - "seconds" parameter is not supported for this profile type
        
    TestHTTPSInsecure: fetch_test.go:590: failed to fetch any source profiles
--- FAIL: TestHTTPSInsecure (0.02s)
=== RUN   TestHTTPSWithServerCertFetch
    TestHTTPSWithServerCertFetch: proftest.go:125: unexpected error: https://localhost:57470/debug/pprof/goroutine: server response: 400 Bad Request - "seconds" parameter is not supported for this profile type
        
    TestHTTPSWithServerCertFetch: fetch_test.go:705: failed to fetch any source profiles
--- FAIL: TestHTTPSWithServerCertFetch (0.02s)

@wyk9787
Copy link
Contributor

wyk9787 commented Apr 22, 2020

Failures look like flakes, or at least not related?

=== RUN   TestHTTPSInsecure
    TestHTTPSInsecure: proftest.go:125: unexpected error: https+insecure://127.0.0.1:57468/debug/pprof/goroutine: server response: 400 Bad Request - "seconds" parameter is not supported for this profile type
        
    TestHTTPSInsecure: fetch_test.go:590: failed to fetch any source profiles
--- FAIL: TestHTTPSInsecure (0.02s)
=== RUN   TestHTTPSWithServerCertFetch
    TestHTTPSWithServerCertFetch: proftest.go:125: unexpected error: https://localhost:57470/debug/pprof/goroutine: server response: 400 Bad Request - "seconds" parameter is not supported for this profile type
        
    TestHTTPSWithServerCertFetch: fetch_test.go:705: failed to fetch any source profiles
--- FAIL: TestHTTPSWithServerCertFetch (0.02s)

Related to #526. Working on the fix to pass those tests.

@codecov-io
Copy link

codecov-io commented Apr 25, 2020

Codecov Report

Merging #525 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #525   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          37       37           
  Lines        7627     7627           
=======================================
  Hits         5114     5114           
  Misses       2105     2105           
  Partials      408      408           
Impacted Files Coverage Δ
internal/driver/commands.go 44.00% <0.00%> (ø)
internal/driver/interactive.go 61.65% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c71eee...7b1b419. Read the comment docs.

@aalexand aalexand merged commit dfef78b into google:master Apr 25, 2020
giordano added a commit to JuliaPackaging/Yggdrasil that referenced this pull request Nov 13, 2020
* Update pprof to latest revision

Bump from 20191205061153 => 20201109224723

My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`)

Includes:
- google/pprof#564
- google/pprof#575
- google/pprof#574
- google/pprof#571
- google/pprof#572
- google/pprof#570
- google/pprof#562
- google/pprof#561
- google/pprof#565
- google/pprof#560
- google/pprof#563
- google/pprof#557
- google/pprof#554
- google/pprof#552
- google/pprof#545
- google/pprof#549
- google/pprof#547
- google/pprof#541
- google/pprof#534
- google/pprof#542
- google/pprof#535
- google/pprof#531
- google/pprof#530
- google/pprof#528
- google/pprof#522
- google/pprof#525
- google/pprof#527
- google/pprof#519
- google/pprof#520
- google/pprof#517
- google/pprof#518
- google/pprof#514
- google/pprof#513
- google/pprof#510
- google/pprof#508
- google/pprof#506
- google/pprof#509
- google/pprof#504

* Update P/pprof/build_tarballs.jl - use a real version number

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

* Remove now unused `timestamp`

* [pprof] Use `GitSource`

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
Fixes google#524

Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] alias 'q' to 'quit'
5 participants