pull from remote master #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also stop supporting Go 1.10 as Go 1.12 is out.
This is similar to such flag in driver_test.go and dotgraph_test.go. I had this change locally for some time, would like to check this in.
This adds flamegraph to the list of dynamic search links so that query parameters are retained when navigating to/from the flamegraph view.
This sorts flamegraph elements lexographiaclly such that two similar profiles can be compared side-by-side to eyeball differences in flamegraph profile shapes and sizes.
* Add go.mod/go.sum * travis: update to test in modules mode and with go1.13 Remove go1.11 setup * fix appveyor config AppVeyor sets the latest go stack in C:\go and that is GOROOT. Cloning this repo under C:\go\src\.. directory confused go build (as discussed in golang/go#34657). The fix in go is not yet released. Thus this commit changes GOPATH to c:\gopath and clones the repo under the directory. Also, this commit removes the go get commands intended to pull in dependencies. In modules mode, `go build` pulls in the required dependencies.
This allows averaging profiles by using: pprof -proto output --divide_by <n> profile1.pb.gz ... profilen.pb.gz
Tag filters like `-tagfilter=foo=1` currently cannot be used to filter by a unitless numeric tag as the tag filter regular expression expects the unit part to be always present. They can be made working by using `-tagfilter=foo=1unit` instead, but that's weird syntax. So fix this by merely making the unit part optional. I was wondering if this simple fix could have any unintended effects but as far as I can tell from testing it does not.
Co-authored-by: Maggie Nolan <nolanmar@google.com>
As per the vet check being introduced in 1.15 (golang/go#32479), conversions of the form string(int) are flagged by go vet. The suggested fix is to instead use string(rune). Additionally, since google/pprof is vendored into the go tree, we avoid test failures from vet flagging this dependency (see CL https://go-review.googlesource.com/c/go/+/220977).
…type (#514) The proto write type code stored in buffer stores unprintable values (e.g. 2 when unmarshalling). The desired output when printing an error message is the string representation of the integer (i.e. strconv.Itoa), instead of the current behavior string(int) or string(rune), which return the utf8 literal corresponding to the integer. As pointed out by @ianlancetaylor in 4ac0da8#commitcomment-37524728, commit 4ac0da8 preserves the previous incorrect behavior to pass a vet check, whereas this change prints the desired output. Updates golang/go#32479.
This keeps the column names visible when scrolling down, which comes in handy when there are many entries.
… empty function (#517) * Check if location has a line with empty function * Include context in the error message that will help triage the error
Add support for output assembly in Intel Syntax.
…ol option. (#519) Provide more helpful error message and require input for every non-bool option.
* Remove seconds parameter * Remove anoter seconds parameter
Fixes #524 Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
Add callgraph examples to README.md Co-authored-by: Maggie Nolan <nolanmar@google.com> Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
* Update the README.md * Update the README.md * Update the README.md * Update the README.md * Update the README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.