Add go.mod to the repository #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove go1.11 setup
AppVeyor sets the latest go stack in C:\go and that is GOROOT. Cloning this repo under C:\go\src\.. directory confused go build (as discussed in golang/go#34657). The fix in go is not yet released. Thus this commit changes GOPATH to c:\gopath and clones the repo under the directory. Also, this commit removes the go get commands intended to pull in dependencies. In modules mode, `go build` pulls in the required dependencies.
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
======================================
Coverage 67.1% 67.1%
======================================
Files 37 37
Lines 7604 7604
======================================
Hits 5103 5103
Misses 2097 2097
Partials 404 404Continue to review full report at Codecov.
|
aalexand
approved these changes
Dec 5, 2019
gmarin13
pushed a commit
to gmarin13/pprof
that referenced
this pull request
Dec 17, 2020
* Add go.mod/go.sum * travis: update to test in modules mode and with go1.13 Remove go1.11 setup * fix appveyor config AppVeyor sets the latest go stack in C:\go and that is GOROOT. Cloning this repo under C:\go\src\.. directory confused go build (as discussed in golang/go#34657). The fix in go is not yet released. Thus this commit changes GOPATH to c:\gopath and clones the repo under the directory. Also, this commit removes the go get commands intended to pull in dependencies. In modules mode, `go build` pulls in the required dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update travis config to tests both in GOPATH mode and modules mode.
While we are here, also update go versions used in travis-ci.