Repository navigation
fix(sitemanage): Xlint this-escape service/listener residual (#2999) - #3060
Merged
Merged
Conversation
Clear PR-sized main-source this-escape cluster after DTO batch (#2980): path services seed protected rootName; final leaf monitors/servlets/ helpers; justified suppress for intentional Spring registry publish on transactional/CGLIB-sensitive beans; proxy template direct field seeds. Tests: PSThisEscapeServiceListenerTest (4). Main this-escape 32->4. Residual: DTO/parser this-escape + serial-field + misc Xlint. Refs #2032 #2200 #2980 > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
force-pushed
the
fix/issue-2999-sitemanage-this-escape-service
branch
from
August 11, 2026 20:56
1cd4ec1 to
8c219c0
Compare
This was referenced Aug 11, 2026
natechadwick
approved these changes
Aug 11, 2026
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partial Xlint cleanup for sitemanage residual issue #2999 (parent module issue #2032, monorepo tracker #2200). After DTO this-escape (#2980 / PR #3000), this PR clears the service / listener / register-on-construct this-escape cluster.
Main changes
rootNamein ctors (no overridablesetRootNameduring construction); keep public finalsetRootNamefor post-construct usePSIndexHelper, servlets,PSServletRequestWrapper,PSProxyAssemblyTemplate,PSMergedRegionTree,PSWidgetPackageResolvercopyBindings@Transactional/ CGLIB-friendly):PSPageImportQueue,PSFolderHelper, listeners, page/widget services, expander registry putTests
PSThisEscapeServiceListenerTest(4): path root seed, proxy seeds, servlet wrapper, finalityInventory (main-source this-escape)
Residual
DTO/parser this-escape leftovers, serial-field residual, misc Xlint, test-source this-escape: #3061
Test plan
cd projects/sitemanage && ../../mvnw.cmd clean install— BUILD SUCCESSPSThisEscapeServiceListenerTest(4) greenextendsof newly final types — none (except intentional non-finalPSSitePathItemServicetest subclasses)Product documentation
Gates / evidence (C3)
projects/sitemanagecd projects/sitemanage && ../../mvnw.cmd clean install→ BUILD SUCCESS; Tests run: 1031, Failures: 0, Errors: 0, Skipped: 125Operator
Operator: Grok: night-issue-prs (model grok-4.5)
Parent: #2032 / #2200
Fixes #2999 (service/listener cluster); residual #3061.