Skip to content

[8.2] sitemanage Xlint residual after this-escape DTO batch (#2032 / #2980) #2999

Closed

Description

@natechadwick-intsof

Parent / tracker: #2200
Slice of: #2032 (sitemanage Xlint)
After: #2980 / this-escape DTO constructor batch (this PR)

Role

Next PR-sized residual for projects/sitemanage main-source -Xlint after DTO this-escape batch.

Dominant remaining clusters (post-#2980)

  1. this-escape service/listener/register (~31) — constructors that register this with Spring/listeners/monitors/path services (e.g. PSPageImportQueue, PSAssetChangeListener, path item services, process monitors, widget builder). Prefer private/final init helpers or justified suppress when publish-to-registry is intentional.
  2. serial-field residual (~14 non-collection) — nested non-serializable types on DTOs.
  3. misc other (~30) — static qualification, equals/hashCode, Hibernate Session.get deprecation, fall-through, redundant cast, etc.
  4. Test-source Xlint — separate batch if main residual still large.

Constraints

  • Prefer real init-order / type fixes; preserve Spring/test wiring types exactly
  • Do not touch rest API contracts unless forced
  • Avoid mega-refactors; one PR-sized cluster (prefer related service/listener this-escape subset, not all remaining at once)
  • cd projects/sitemanage && ../../mvnw.cmd clean install must stay green
  • If more than one PR remains after that slice, file another residual child

Leave unassigned.

Co-Authored by Grok Build using grok-4.5 with agent main.

Activity

  1. natechadwick-intsof commented on Aug 11, 2026

    @natechadwick-intsof
    CollaboratorAuthor

    night-issue-prs: starting work on sitemanage this-escape service/listener residual (operator:grok / model:grok-4.5).

  2. natechadwick-intsof commented on Aug 11, 2026

    @natechadwick-intsof
    CollaboratorAuthor

    PR opened: #3060

    Service/listener this-escape residual: main-source this-escape 32 → 4.

    Closing this issue as the service/listener cluster is delivered; remaining work tracked on #3061.

    Co-Authored by Grok Build using grok-4.5 with agent main.

  3. natechadwick-intsof commented on Aug 11, 2026

    @natechadwick-intsof
    CollaboratorAuthor

    Work complete for service/listener this-escape slice; see PR #3060. Residual #3061 filed for remaining sitemanage Xlint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions