Skip to content

[8.2] sitemanage Xlint residual after unchecked batch (#2032 / #2895) #2980

Closed

Description

@natechadwick-intsof

Parent / tracker: #2200
Slice of: #2032 (sitemanage Xlint)
After: #2895 / PR #2979 (unchecked/rawtypes cleared)
Also after: #2870 batch 3 serial-field collections (PR #2896)

Role

Next PR-sized residual for projects/sitemanage main-source -Xlint after unchecked/rawtypes cleanup.

Dominant remaining clusters (from live inventory after #2895)

  1. this-escape (~55) — constructor patterns calling overridable methods / registering listeners. Prefer real init-order fixes or targeted suppress with justification.
  2. serial-field residual (~14 non-collection after batch 3 merges) — nested non-serializable types on DTOs. Prefer real Serializable types or justified transient.
  3. misc other (~33) — static qualification, equals/hashCode, Hibernate Session.get deprecation, fall-through, redundant cast, etc. Coherent small packages OK if grouped.
  4. Test-source Xlint — separate batch if main residual still large.

Constraints

  • Prefer real init-order / type fixes; preserve Spring/test wiring types exactly
  • Do not touch rest API contracts unless forced
  • Avoid mega-refactors; one PR-sized cluster (~30–80 warnings or one coherent package set)
  • cd projects/sitemanage && ../../mvnw.cmd clean install must stay green
  • If more than one PR remains after this slice, file another residual child

Leave unassigned.

Co-Authored by Grok Build using grok-4.5 with agent main.

Activity

  1. natechadwick-intsof commented on Aug 11, 2026

    @natechadwick-intsof
    CollaboratorAuthor

    night-issue-prs: starting work on sitemanage this-escape residual batch.

    Co-Authored by Grok Build using grok-4.5 with agent main.

  2. natechadwick-intsof commented on Aug 11, 2026

    @natechadwick-intsof
    CollaboratorAuthor

    Done for this slice: PR #3000 clears DTO/data this-escape constructor cluster (main this-escape 50→31 in capped report). Residual next PR-sized work: #2999 (service/listener this-escape + serial-field + misc). Closing #2980 as implemented by the PR; remaining work tracked on #2999 / #2032.

    Co-Authored by Grok Build using grok-4.5 with agent main.

  3. natechadwick-intsof commented on Aug 11, 2026

    @natechadwick-intsof
    CollaboratorAuthor

    Implemented via PR #3000; residual #2999 for remaining sitemanage Xlint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions