Repository navigation
fix(sitemanage): Xlint batch 3 — serial-field concrete collections (#2870) - #2896
Merged
Merged
Conversation
…2870) Convert main-source serializable DTO collection fields from bare List/Map/Set interfaces to ArrayList/HashMap/HashSet/Vector so -Xlint:serial serial-field diagnostics clear. Public getter/setter API types stay interfaces. Setters share the argument when it is already the concrete type (JAXB-safe) and copy otherwise. Extends PSSerializableListWrappersTest for field types and LinkedList defensive-copy behavior. Live main warnings ~227->165; serial-field 86->14. Fixes #2870 Refs #2032 #2200 #2421 > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added
operator:grok
This was referenced Aug 11, 2026
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Previous Review Summary (commit 84ee7b8)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 84ee7b8)Status: 6 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
WARNING
SUGGESTION
Files Reviewed (31 files)
Reviewed by step-3.7-flash · Input: 68.2K · Output: 13.9K · Cached: 703.9K Review guidance: REVIEW.md from base branch |
- Fix PSSectionNode.setChildNodes malformed nested ternary; share-if-concrete ArrayList - Drop dead null branches after notNull/requireNonNull in PSContentItem, PSRegionCSS, PSRegionCssList, PSWidgetBuilderFieldsListData, PSWidgetBuilderResourceListData - Extend PSSerializableListWrappersTest for share/copy behavior on reviewed setters Evidence: cd projects/sitemanage; ../../mvnw.cmd clean install → BUILD SUCCESS (Tests run: 898, Failures: 0, Errors: 0, Skipped: 127) > Co-Authored by Grok CLI using grok-4 with agent night-issue-prs-post-work.
This was referenced Aug 11, 2026
natechadwick
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partial Xlint cleanup for sitemanage residual issue #2870 (parent module issue #2032, monorepo tracker #2200). Batch 3 clears the dominant serial-field cluster on main-source JAXB/JSON DTOs by using concrete serializable collection field types.
Main changes
List/Collection→ArrayList,Map→HashMap,Set→HashSet, and oneVectorbindings field (PSProxyAssemblyTemplate)List/Map/Set) — no REST/API contract change@SuppressWarnings("unchecked")on share-if-concrete setters for the generic cast afterinstanceofTests
PSSerializableListWrappersTest— concrete field-type guards + LinkedList input defensive-copy behaviorInventory (main-source, uncapped
-Xmaxwarns)Residual
Remaining main diagnostics: this-escape, unchecked/raw, ~14 non-collection serial-field. Residual child filed after this PR.
Test plan
cd projects/sitemanage && ../../mvnw.cmd clean install— BUILD SUCCESSProduct documentation
Gates / evidence (C3)
projects/sitemanagecd projects/sitemanage && ../../mvnw.cmd clean install→ BUILD SUCCESS; Tests run: 970, Failures: 0, Errors: 0, Skipped: 127docs/ai-generated/code-reviews/issue-2870-sitemanage-xlint-serial-field-erlang.mdFixes #2870
Refs #2032 #2200 #2421