Repository navigation
fix(sitemanage): Xlint this-escape DTO/parser + serial-field residual (#3061) - #3106
Merged
Merged
Conversation
…#3061) Clear remaining main-source this-escape (5→0) and serial-field (14→0) in projects/sitemanage after #2999/PR#3060. Direct field seeds for DTO/path ctors, lazy region parser factory, Serializable nested data holders, transient runtime refs. Tests: PSThisEscapeDtoConstructorTest + PSSerialFieldResidualTest. clean install green (1082 tests). Fixes #3061 Parent: #2032 / #2200 > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added
operator:grok
This was referenced Aug 12, 2026
Collaborator
Author
|
Residual for remaining sitemanage main-source misc Xlint (~37) + later test-source: #3107
|
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Previous Review Summary (commit f227c1d)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit f227c1d)Status: 6 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (7 files with issues)
Reviewed by step-3.7-flash · Input: 55.5K · Output: 4.5K · Cached: 238.5K Review guidance: REVIEW.md from base branch |
- Thread-safe double-checked lazy PSRegionParserAdapter - getCyclicalResources never null after deserial - PSPubInfo credential fields transient; test asserts null after round-trip - Drop misleading transient on servlet assetCreator - PSMapWrapper / WidgetPrefs.icon use interface field types > Co-Authored by Grok CLI using grok with agent overnight-pr-followup.
natechadwick
approved these changes
Aug 12, 2026
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partial Xlint cleanup for sitemanage residual issue #3061 (parent module issue #2032, monorepo tracker #2200). After service/listener this-escape (#2999 / PR #3060), this PR clears the DTO/parser this-escape leftovers and the serial-field non-collection residual.
Main changes
PSUnusedAssetSummary,PSWidgetBuilderSummaryData/PSWidgetBuilderDefinitionData; lazy parser factory inPSRegionParserAdapter; seedrootNameonPSFoldersPathItemService(missed leaf from [8.2] sitemanage Xlint residual after this-escape DTO batch (#2032 / #2980) #2999)Serializableon nested data holders (PSMapWrapper,PSPubInfo,PSRenderLink,PSResourceLocation, widget nested prefs/content/code);transientfor runtime-only refs (relatedObject, JCRNode, servlet collaborator, CMSPSObjectAcl); cycle exception keeps in-process definitions transient + serializable id list for messages; justified@SuppressWarnings("serial")on JPAPropertyIdonlyTests
PSThisEscapeDtoConstructorTest(+3): widget builder DAO seeds, null DAO, region parser adapterPSSerialFieldResidualTest(7): Serializable types, transient field guards, Java serialization round-tripsInventory (main-source)
Residual
Misc main-source Xlint (static qualification, Hibernate
Session.getdeprecation, equals/hashCode, fall-through, redundant cast, unchecked, …) and test-source Xlint: filed as follow-up under #2032 / #2200.Test plan
cd projects/sitemanage && ../../mvnw.cmd clean install— BUILD SUCCESSPSThisEscapeDtoConstructorTest,PSSerialFieldResidualTest,PSFoldersPathItemServiceTest,PSThisEscapeServiceListenerTest— greenfinal/sealed; no public signature removals — greps N/AProduct documentation
Gates / evidence (C3)
projects/sitemanagecd projects/sitemanage && ../../mvnw.cmd clean install→ BUILD SUCCESS; Tests run: 1082, Failures: 0, Errors: 0, Skipped: 125Operator
Operator: Grok: night-issue-prs (model grok-4.5)
Parent: #2032 / #2200
Fixes #3061 (this-escape DTO/parser + serial-field residual).