Update windows APPDATA location #769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add wrongly removed statement back to codebase This was removed in the process of making the linter happy. But it is required since it changes `num_channels`. * remove unused commented out logging
Slcan review General review of slcan.py - add read method to enhance abstraction - add flush method - add get_serial_number, to retrive the serial number of the CANbus-serial bridge (also add test case) - add get_version, to retrive the version of the CANbus-serial bridge (also add test case) - wrap up stuff related to bitrate setting in dedicated methods - make write method private/hidden
It is unsupported and causes problems. See [here](#554 (comment)).
christiansandberg
approved these changes
Mar 10, 2020
hardbyte
approved these changes
Mar 10, 2020
|
@hardbyte can you re-trigger Travis? OSX failure are unrelated. Thank you |
Avoid calling msg.data multiple times by caching msg.data value
Co-authored-by: zariiii9003 <zariiii9003@users.noreply.github.com> Co-authored-by: Christian Sandberg <christiansandberg@users.noreply.github.com>
Socketcan bcm now supports sending periodic messages with the same arbitration ID. Updates documentation and tests for socketcan interface. Closes #721
Clarification for Notifier docs
This works towards PEP 561 compatibility.
only import winreg when on Windows
In Python 2, the str type was used for text and bytes, whereas in Python 3, these are separate and incompatible types. This broke instantiation of a VectorBus when the app_name parameter in __init__ was set to None. This correctly sets it to a bytes object. Fixes #796
|
@hardbyte, @christiansandberg, @felixdivo who can re-trigger Travis OSX build or merge this PR? |
|
I can't, @hardbyte can |
I've triggered a rebuild, but I thought you would both be able to? https://docs.travis-ci.com/user/travis-ci-for-private/#who-has-access-to-the-builds
|
|
Oh my bad, I was in a wrong browser instance where I was somehow signed out. Sorry! Strange that the build suddenly fails ... maybe #745 has returned? |
Co-authored-by: Felix Divo <felixdivo@users.noreply.github.com>
This works towards PEP 561 compatibility.
* Add an error callback to ThreadBasedCyclicSendTask * Fix formatting error reported by black * Add return value for on_error * unit tests * black * review comments Co-authored-by: Felix Divo <felixdivo@users.noreply.github.com>
pierreluctg
force-pushed
the
pierreluctg-patch-1
branch
from
5a28dad to
9291c43
Compare
|
Replaced with #831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.