Skip to content

Add TX/RX message direction to socketcan #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2020

Conversation

tysonite
Copy link
Contributor

@tysonite tysonite commented Feb 26, 2020

References #773 and #776

@tysonite
Copy link
Contributor Author

tysonite commented Feb 26, 2020

Don't judge me too much, please. :) My first try to submit something there. I actually got a pointer to implement that looking into candump tool and SocketCAN doc 4.1.7 section.

Also, I am not sure if this change also needs to take into account ancdata returned by recvmsg (https://docs.python.org/3/library/socket.html#socket.socket.recvmsg).

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #780 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #780      +/-   ##
==========================================
+ Coverage    69.48%   69.5%   +0.02%     
==========================================
  Files           70      70              
  Lines         6557    6556       -1     
==========================================
+ Hits          4556    4557       +1     
+ Misses        2001    1999       -2

Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @tysonite

@hardbyte hardbyte merged commit a35ab98 into hardbyte:develop Apr 4, 2020
@tysonite tysonite deleted the txrx_socketcan branch April 4, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants