Skip to content

Update test deps #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Update test deps #745

merged 2 commits into from
Dec 23, 2019

Conversation

hardbyte
Copy link
Owner

@hardbyte hardbyte commented Dec 23, 2019

Pinning an old version of coverage avoids a coverage bug we are running into - see this failing travis build on develop with travis on MACOS on Python3.6.0 where after the tests are complete we get an internal error:

INTERNALERROR> Traceback (most recent call last):

INTERNALERROR>   File "/Users/travis/virtualenv/python3.6-dev/lib/python3.6/site-packages/coverage/sqldata.py", line 1032, in execute

INTERNALERROR>     return self.con.execute(sql, parameters)

INTERNALERROR> sqlite3.OperationalError: Safety level may not be changed inside a transaction

INTERNALERROR> 

Appears to be nedbat/coveragepy#703

codecov installs coverage, and this seems to have a problem on MACOS using Python3.6.0
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #745 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #745      +/-   ##
===========================================
+ Coverage    69.51%   69.52%   +0.01%     
===========================================
  Files           70       70              
  Lines         6485     6485              
===========================================
+ Hits          4508     4509       +1     
+ Misses        1977     1976       -1

@hardbyte hardbyte merged commit 638bbeb into develop Dec 23, 2019
@hardbyte hardbyte deleted the update-test-deps branch December 23, 2019 09:18
hardbyte added a commit that referenced this pull request Dec 28, 2019
* Update pinned versions of testing dependencies
* Pin version of coverage
hardbyte added a commit that referenced this pull request Dec 28, 2019
* pin versions of testing dependencies including coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant