Skip to content

Add an error callback to ThreadBasedCyclicSendTask #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 5, 2020
Merged

Add an error callback to ThreadBasedCyclicSendTask #781

merged 7 commits into from
May 5, 2020

Conversation

tysonite
Copy link
Contributor

References #743

@codecov
Copy link

codecov bot commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #781 into develop will increase coverage by 0.06%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop     #781      +/-   ##
===========================================
+ Coverage    69.75%   69.81%   +0.06%     
===========================================
  Files           70       70              
  Lines         6599     6603       +4     
===========================================
+ Hits          4603     4610       +7     
+ Misses        1996     1993       -3

pierreluctg
pierreluctg reviewed Feb 27, 2020
View reviewed changes
christiansandberg
christiansandberg reviewed Feb 29, 2020
View reviewed changes
@tysonite
Copy link
Contributor Author

tysonite commented Apr 4, 2020

Any other comments, guys?

felixdivo
felixdivo approved these changes May 4, 2020
View reviewed changes
Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @pierreluctg will you merge it?

@felixdivo felixdivo merged commit fa9df7b into hardbyte:develop May 5, 2020
@felixdivo felixdivo added this to the 4.0 Release milestone May 5, 2020
@felixdivo
Copy link
Collaborator

Sorry @tysonite for the delay

@tysonite
Copy link
Contributor Author

tysonite commented May 5, 2020

Thanks! Appreciate it

@sou1hacker sou1hacker mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreluctg pierreluctg pierreluctg approved these changes

@felixdivo felixdivo felixdivo approved these changes

@christiansandberg christiansandberg Awaiting requested review from christiansandberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@tysonite @felixdivo @pierreluctg @christiansandberg