-
Notifications
You must be signed in to change notification settings - Fork 638
Slcan review #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slcan review #611
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #611 +/- ##
==========================================
+ Coverage 63.65% 63.8% +0.15%
==========================================
Files 63 63
Lines 5544 5606 +62
==========================================
+ Hits 3529 3577 +48
- Misses 2015 2029 +14 |
Codecov Report
@@ Coverage Diff @@
## develop #611 +/- ##
=========================================
+ Coverage 63.85% 64% +0.14%
=========================================
Files 63 63
Lines 5545 5607 +62
=========================================
+ Hits 3541 3589 +48
- Misses 2004 2018 +14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first: Thanks for helping!
I think we should document the newly added methods.
While we're at it: shouldn't cc @hardbyte Apart from that we can merge this. |
You know, I was thinking the same yesterday when I was trying to amend for you comments, but I didn't want to go too far. |
I think it is fine without a depreciation period - |
Nice! Thanks again @albertoscotta 😄 |
General review of slcan.py