ref(event_manager): Inline signals into _record_transaction_info #86604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
untitaker
approved these changes
Mar 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #86604 +/- ##
===========================================
+ Coverage 45.37% 87.80% +42.42%
===========================================
Files 9759 9774 +15
Lines 552916 553326 +410
Branches 21693 21576 -117
===========================================
+ Hits 250889 485822 +234933
+ Misses 301632 67133 -234499
+ Partials 395 371 -24 |
JoshFerge
approved these changes
Mar 7, 2025
|
Turns out we do need |
* master: (57 commits) ref(getting-started): Change code to always update loader script when products changes (#86583) ref(spans): Detect performance issues directly in segments consumer (#86595) ref(getting-started): Update copies, replacing 'Sentry dashboard' with 'Sentry Issues' (#86672) ref(product-selection): Update code to not strip url (#86582) ref(quick-start): Replace 'record' with 'create_or_update' in 'record_new_project' (#86663) ref(assemble): Remove old `find_missing_chunks` method (#86588) fix(views):Exclude newly added views from last visited update as well (#86653) feat(workflow_engine): Only execute enabled Detectors (#86652) fix(autofix): Github links, remove seer branding, and UI cleanup (#86640) fix(seer-issues-patch) More parsing of functions for Python (#86558) ref(ui): Remove sentry.eot (#86649) feat(alerts): Restrict uptime/crons overview buttons for alerts:write (#86436) chore(deps): bump axios from 1.7.7 to 1.8.2 (#86642) deps(ui): Upgrade prettier (#86634) deps(ui): Upgrade eslint, biome (#86630) fix(shared-views): Fix default view passing to last visited endpoint (#86632) feat(billing): update copy for payg disabled CTA (#86143) ref(ui): Remove usage of withOrganization from organizationAuthList (#86554) fix(crons): Fix disabled state of disable button (#86637) feat(ui): Replace OrganizationAuth DeprecatedAsyncComponent (#86556) ...
jan-auer
force-pushed
the
ref/em-simplify-signals
branch
from
eb5bf5a to
2f484e1
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
DominikB2014
pushed a commit
that referenced
this pull request
Mar 14, 2025
…pan (#87123) Fixes a regression introduced in #86604 that resulted in a captured `TypeError` when recording the first insight span for a project. We switched from using signals, which are prohibited in `EventManager.save`, to directly calling the onboarding receiver function. In this specific instance, we missed that the function was decorated, and the import resulted in `None`. For an unknown reason, the resulting `TypeError` did not show up in Sentry. Projects that have not recorded these flags since the regression was rolled out will be flagged when they ingest the next span of the corresponding insights module.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralizes all transaction-related side effects in
_record_transaction_infoso it can be moved into the new spans consumer. This follows up to prior work by
@JoshFerge.
event_manager.save. The underlyingfunctions are now called directly and the calls have been moved in.
record_*functions that were called directly totheir old signals.
Ref https://github.com/getsentry/streaming-planning/issues/67