Skip to content

ref(assemble): Remove old find_missing_chunks method #86588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

iambriccardo
Copy link
Contributor

@iambriccardo iambriccardo commented Mar 7, 2025

This PR removes the old find_missing_chunks method in favor of the new one.

@iambriccardo iambriccardo requested a review from Swatinem March 7, 2025 09:50
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 7, 2025
@iambriccardo iambriccardo changed the title ref(assemble): Remove old ref(assemble): Remove old find_missing_chunks method Mar 7, 2025
@iambriccardo iambriccardo marked this pull request as ready for review March 7, 2025 09:56
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #86588   +/-   ##
=======================================
  Coverage   87.79%   87.79%           
=======================================
  Files        9771     9771           
  Lines      553338   553306   -32     
  Branches    21640    21640           
=======================================
- Hits       485820   485794   -26     
+ Misses      67147    67141    -6     
  Partials      371      371           

@iambriccardo iambriccardo merged commit b7bf581 into master Mar 10, 2025
49 checks passed
@iambriccardo iambriccardo deleted the riccardo/ref/remove-old-assemble branch March 10, 2025 07:12
jan-auer added a commit that referenced this pull request Mar 10, 2025
* master: (57 commits)
  ref(getting-started): Change code to always update loader script when products changes (#86583)
  ref(spans): Detect performance issues directly in segments consumer (#86595)
  ref(getting-started): Update copies, replacing 'Sentry dashboard' with 'Sentry Issues' (#86672)
  ref(product-selection): Update code to not strip url (#86582)
  ref(quick-start): Replace 'record' with 'create_or_update' in 'record_new_project' (#86663)
  ref(assemble): Remove old `find_missing_chunks` method (#86588)
  fix(views):Exclude newly added views from last visited update as well (#86653)
  feat(workflow_engine): Only execute enabled Detectors (#86652)
  fix(autofix): Github links, remove seer branding, and UI cleanup (#86640)
  fix(seer-issues-patch) More parsing of functions for Python (#86558)
  ref(ui): Remove sentry.eot (#86649)
  feat(alerts): Restrict uptime/crons overview buttons for alerts:write (#86436)
  chore(deps): bump axios from 1.7.7 to 1.8.2 (#86642)
  deps(ui): Upgrade prettier (#86634)
  deps(ui): Upgrade eslint, biome (#86630)
  fix(shared-views): Fix default view passing to last visited endpoint (#86632)
  feat(billing): update copy for payg disabled CTA (#86143)
  ref(ui): Remove usage of withOrganization from organizationAuthList (#86554)
  fix(crons): Fix disabled state of disable button (#86637)
  feat(ui): Replace OrganizationAuth DeprecatedAsyncComponent (#86556)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants