Skip to content

ref(ui): Remove usage of withOrganization from organizationAuthList #86554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner March 6, 2025 21:58
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team March 6, 2025 21:58
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
9664 2 9662 10
View the top 2 failed test(s) by shortest run time
OrganizationAuthList with 2fa warning renders with saml available
Stack Traces | 0.025s run time
TestingLibraryElementError: Unable to find an element with the text: Require 2FA will be disabled if you enable SSO.. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../settings/organizationAuth/organizationAuthList.spec.tsx:66:42)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
OrganizationAuthList with 2fa warning renders
Stack Traces | 0.044s run time
TestingLibraryElementError: Unable to find an element with the text: Require 2FA will be disabled if you enable SSO.. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../settings/organizationAuth/organizationAuthList.spec.tsx:55:42)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-ui-remove-usage-of-withorganization-from-organizationauthlist branch from 8729a17 to 68c4846 Compare March 7, 2025 22:52
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) March 7, 2025 22:52
@evanpurkhiser evanpurkhiser merged commit 23e6996 into master Mar 7, 2025
42 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-ui-remove-usage-of-withorganization-from-organizationauthlist branch March 7, 2025 23:07
jan-auer added a commit that referenced this pull request Mar 10, 2025
* master: (57 commits)
  ref(getting-started): Change code to always update loader script when products changes (#86583)
  ref(spans): Detect performance issues directly in segments consumer (#86595)
  ref(getting-started): Update copies, replacing 'Sentry dashboard' with 'Sentry Issues' (#86672)
  ref(product-selection): Update code to not strip url (#86582)
  ref(quick-start): Replace 'record' with 'create_or_update' in 'record_new_project' (#86663)
  ref(assemble): Remove old `find_missing_chunks` method (#86588)
  fix(views):Exclude newly added views from last visited update as well (#86653)
  feat(workflow_engine): Only execute enabled Detectors (#86652)
  fix(autofix): Github links, remove seer branding, and UI cleanup (#86640)
  fix(seer-issues-patch) More parsing of functions for Python (#86558)
  ref(ui): Remove sentry.eot (#86649)
  feat(alerts): Restrict uptime/crons overview buttons for alerts:write (#86436)
  chore(deps): bump axios from 1.7.7 to 1.8.2 (#86642)
  deps(ui): Upgrade prettier (#86634)
  deps(ui): Upgrade eslint, biome (#86630)
  fix(shared-views): Fix default view passing to last visited endpoint (#86632)
  feat(billing): update copy for payg disabled CTA (#86143)
  ref(ui): Remove usage of withOrganization from organizationAuthList (#86554)
  fix(crons): Fix disabled state of disable button (#86637)
  feat(ui): Replace OrganizationAuth DeprecatedAsyncComponent (#86556)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants