feat(ui): Replace OrganizationAuth DeprecatedAsyncComponent #86556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
commented
Mar 6, 2025
| * TODO(epurkhiser): This does not work right now as we still fallback to the | ||
| * old SSO auth configuration page | ||
| */ | ||
| handleConfigure = (provider: AuthProvider) => { |
There was a problem hiding this comment.
Just removing these because they were unused and it's very unlikely we need to reference this code in the future
scttcper
reviewed
Mar 6, 2025
Comment on lines
15
to
19
| const {data: providerList, isLoading: loadingProviders} = useApiQuery<AuthProvider[]>( | ||
| [`/organizations/${organization.slug}/auth-providers/`], | ||
| {staleTime: 0} | ||
| ); | ||
| const {data: provider, isLoading: loadingProvider} = useApiQuery<AuthProvider>( |
There was a problem hiding this comment.
Suggested change
| const {data: providerList, isLoading: loadingProviders} = useApiQuery<AuthProvider[]>( | |
| [`/organizations/${organization.slug}/auth-providers/`], | |
| {staleTime: 0} | |
| ); | |
| const {data: provider, isLoading: loadingProvider} = useApiQuery<AuthProvider>( | |
| const {data: providerList, isPending: loadingProviders} = useApiQuery<AuthProvider[]>( | |
| [`/organizations/${organization.slug}/auth-providers/`], | |
| {staleTime: 0} | |
| ); | |
| const {data: provider, isPending: loadingProvider} = useApiQuery<AuthProvider>( |
scttcper
reviewed
Mar 6, 2025
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-ui-replace-organizationauth-deprecatedasynccomponent
branch
from
d9b50cb to
7f3fa42
Compare
scttcper
approved these changes
Mar 7, 2025
scttcper
reviewed
Mar 7, 2025
Comment on lines
+16
to
+28
| const { | ||
| data: providerList, | ||
| isLoading: loadingProviders, | ||
| error: errorProviders, | ||
| } = useApiQuery<AuthProvider[]>( | ||
| [`/organizations/${organization.slug}/auth-providers/`], | ||
| {staleTime: 0} | ||
| ); | ||
| const { | ||
| data: provider, | ||
| isLoading: loadingProvider, | ||
| error: errorProvider, | ||
| } = useApiQuery<AuthProvider>([`/organizations/${organization.slug}/auth-provider/`], { |
There was a problem hiding this comment.
Suggested change
| const { | |
| data: providerList, | |
| isLoading: loadingProviders, | |
| error: errorProviders, | |
| } = useApiQuery<AuthProvider[]>( | |
| [`/organizations/${organization.slug}/auth-providers/`], | |
| {staleTime: 0} | |
| ); | |
| const { | |
| data: provider, | |
| isLoading: loadingProvider, | |
| error: errorProvider, | |
| } = useApiQuery<AuthProvider>([`/organizations/${organization.slug}/auth-provider/`], { | |
| const { | |
| data: providerList, | |
| isPending: loadingProviders, | |
| error: errorProviders, | |
| } = useApiQuery<AuthProvider[]>( | |
| [`/organizations/${organization.slug}/auth-providers/`], | |
| {staleTime: 0} | |
| ); | |
| const { | |
| data: provider, | |
| isPending: loadingProvider, | |
| error: errorProvider, | |
| } = useApiQuery<AuthProvider>([`/organizations/${organization.slug}/auth-provider/`], { |
evanpurkhiser
deleted the
evanpurkhiser/feat-ui-replace-organizationauth-deprecatedasynccomponent
branch
jan-auer
added a commit
that referenced
this pull request
Mar 10, 2025
* master: (57 commits) ref(getting-started): Change code to always update loader script when products changes (#86583) ref(spans): Detect performance issues directly in segments consumer (#86595) ref(getting-started): Update copies, replacing 'Sentry dashboard' with 'Sentry Issues' (#86672) ref(product-selection): Update code to not strip url (#86582) ref(quick-start): Replace 'record' with 'create_or_update' in 'record_new_project' (#86663) ref(assemble): Remove old `find_missing_chunks` method (#86588) fix(views):Exclude newly added views from last visited update as well (#86653) feat(workflow_engine): Only execute enabled Detectors (#86652) fix(autofix): Github links, remove seer branding, and UI cleanup (#86640) fix(seer-issues-patch) More parsing of functions for Python (#86558) ref(ui): Remove sentry.eot (#86649) feat(alerts): Restrict uptime/crons overview buttons for alerts:write (#86436) chore(deps): bump axios from 1.7.7 to 1.8.2 (#86642) deps(ui): Upgrade prettier (#86634) deps(ui): Upgrade eslint, biome (#86630) fix(shared-views): Fix default view passing to last visited endpoint (#86632) feat(billing): update copy for payg disabled CTA (#86143) ref(ui): Remove usage of withOrganization from organizationAuthList (#86554) fix(crons): Fix disabled state of disable button (#86637) feat(ui): Replace OrganizationAuth DeprecatedAsyncComponent (#86556) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.