Skip to content

fix(event_manager): Resolve TypeError while recording first insight span #87123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Mar 14, 2025

Fixes a regression introduced in #86604 that resulted in a captured
TypeError when recording the first insight span for a project.

We switched from using signals, which are prohibited in
EventManager.save, to directly calling the onboarding receiver
function. In this specific instance, we missed that the function was
decorated, and the import resulted in None. For an unknown reason, the
resulting TypeError did not show up in Sentry.

Projects that have not recorded these flags since the regression was
rolled out will be flagged when they ingest the next span of the
corresponding insights module.

@jan-auer jan-auer requested a review from a team as a code owner March 14, 2025 20:04
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 14, 2025
@DominikB2014 DominikB2014 self-requested a review March 14, 2025 20:08
@DominikB2014 DominikB2014 enabled auto-merge (squash) March 14, 2025 20:14
@DominikB2014 DominikB2014 merged commit 66b5981 into master Mar 14, 2025
51 checks passed
@DominikB2014 DominikB2014 deleted the fix/set-project-insight-flag branch March 14, 2025 20:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants