Port changes for release v1.0.19 and Changelog #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Metadata format support * Fix duplicates, added tests. * Swapped logic for metadata with content. * Lint updates * Lint changes
@W-7948971@
* Add slack integration and change publish process * Update default publish-type
brpowell
reviewed
Aug 13, 2020
brpowell
reviewed
Aug 13, 2020
Apply suggestions from code review Co-authored-by: Bryan Powell <b.powell@salesforce.com>
sfsholden
force-pushed
the
sh/port-v1.0.19
branch
from
4757a11 to
5a61839
Compare
|
@sfsholden @brpowell I think this PR looks good. Just to confirm, we are not porting PR #112 as part of this since it just got merged earlier today, right ? |
@sfsholden Actually, can that commit be included as well? |
|
@brpowell Yes, I'm going to hold off on porting it until the QA is complete - just in case there are additional changes needed. |
|
@brpowell Just got the go ahead from Jag. I'll port that change now |
lcampos
approved these changes
Aug 13, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?