Metadata format support #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brpowell
reviewed
Aug 6, 2020
| export const SEAN_FOLDER = join(SEAN_DIR, 'A_Folder'); | ||
| export const SEAN_NAMES = ['a.sean', 'b.sean', 'c.sean']; | ||
| export const SEAN_PATHS = SEAN_NAMES.map(p => join(SEAN_FOLDER, p)); | ||
| export const SEAN_COMPONENTS: SourceComponent[] = [ |
There was a problem hiding this comment.
i like my components shaken, not stirred
brpowell
reviewed
Aug 6, 2020
| /** | ||
| * Control whether combined (metadata and content) metadata files are allowed for an adapter. | ||
| */ | ||
| public allowContentMetadataXml(): boolean { |
There was a problem hiding this comment.
Two minor nits:
- Can we rebrand this concept as "metadata with content" to mean the types that have some sort of binary data in addition to the metadata xml? Mostly to stay consistent with Metadata and MetadataWithContent as documented in the api. So the default and decomposed source adapters would be
falseand the resttrue - This is similar to the
ownFolderproperty in the adapters because it describes the kind of metadata the adapter handles. Can we either make both descriptors a getter method like it is here, or a simple protected property likeownFolderis?
brpowell
approved these changes
Aug 10, 2020
sfsholden
pushed a commit
that referenced
this pull request
Aug 13, 2020
* Metadata format support * Fix duplicates, added tests. * Swapped logic for metadata with content. * Lint updates * Lint changes
sfsholden
pushed a commit
that referenced
this pull request
Aug 13, 2020
* Metadata format support * Fix duplicates, added tests. * Swapped logic for metadata with content. * Lint updates * Lint changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides component resolution for metadata files that are in metadata (non-decomposed) format.
What issues does this PR fix or reference?
@W-7618945@