Retry code coverage upload 3 times and don't fail build #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyc
reviewed
Aug 11, 2020
scripts/uploadCodeCoverage.js
Outdated
| message += ' - trying again...'; | ||
| } | ||
| console.log(message); | ||
| console.log(e.message) |
There was a problem hiding this comment.
nit
Suggested change
| console.log(e.message) | |
| console.log(e.message); |
xyc
reviewed
Aug 11, 2020
| @@ -0,0 +1,22 @@ | |||
| const { execSilent } = require('./util'); | |||
There was a problem hiding this comment.
shebang and wait for @lcampos for license comment :)
xyc
approved these changes
Aug 11, 2020
brpowell
commented
Aug 12, 2020
| @@ -67,7 +67,7 @@ | |||
| "local:install": "./scripts/localInstall.js install", | |||
| "local:link": "./scripts/localInstall.js link", | |||
| "local:unlink": "./scripts/localInstall.js unlink", | |||
| "test": "shx rm -rf ./test-results && nyc mocha && node ./scripts/verifyTestArtifacts", | |||
There was a problem hiding this comment.
Removed verifyTestArtifacts script because this used to help guard against silent compile errors in the test job. Now that we removed ts-node and compile tests in the build phase, we have that protection "built in" now.
lcampos
reviewed
Aug 12, 2020
| @@ -0,0 +1,32 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
We might want to change the perms on this file so it's executable, similar to the publish.js script (-rwxr-xr-x vs -rw-r--r--)
lcampos
approved these changes
Aug 12, 2020
brpowell
force-pushed
the
bp/codeCovRetry
branch
from
4739e89 to
0358b6a
Compare
sfsholden
pushed a commit
that referenced
this pull request
Aug 13, 2020
sfsholden
pushed a commit
that referenced
this pull request
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since uploading code coverage to codecov.io can be flaky with connection issues, this script retries an additional 2 times which is often all it takes to succeed. If it fails after 3 tries the job will still exit 0 to not fail the build.
What issues does this PR fix or reference?
@W-7939127@