Skip to content

Add Slack Integration and Update Publish Process (@W-7953925) #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

sfsholden
Copy link
Contributor

What does this PR do?

  1. Adds slack integration with CircleCi.
  2. Changes release process to follow the new API call flow instead of releasing whenever a merge into main occurs.

What issues does this PR fix or reference?

@W-7953925@

@sfsholden sfsholden requested a review from a team as a code owner August 12, 2020 22:02
color: '#0E1111'
- node-latest
- node-12
- node-10
Copy link
Contributor Author

@sfsholden sfsholden Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the cache job needed here as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 4 jobs restore the cache for themselves already I believe - is that what you mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm referring to this piece here. I don't think it's needed, but wanted to pose the question just in case:

      - cache:
          filters:
            tags:
              only: /^v.*/
            branches:
              ignore: /.*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's needed, at least not with that specific config

@sfsholden sfsholden changed the title Add Slack Integration and Update Publish Process Add Slack Integration and Update Publish Process (@W-7953925) Aug 12, 2020
@@ -4,6 +4,15 @@ version: 2.1
orbs:
win: circleci/windows@2.2.0
sfchangecase: salesforce/change-case-management@3
slack: circleci/slack@3.4.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference - there's additional setup that has to take place for the slack integration. This is the guide I am following.

Section:

To get started with enabling notifications in Slack for a specific project, head to the Settings page for your project. Click on Slack Integration in the sidebar and follow the steps to setup Slack.

@sfsholden
Copy link
Contributor Author

@lcampos It looks like we need to change the required status from the CircleCi workflow from 'deploy-and-retrieve' to 'commit-workflow'. I don't believe I have the appropriate access to change it.

@sfsholden sfsholden merged commit 8a04524 into develop Aug 13, 2020
@sfsholden sfsholden deleted the sh/releaseProcessChange branch August 13, 2020 16:33
sfsholden added a commit that referenced this pull request Aug 13, 2020
* Add slack integration and change publish process

* Update default publish-type
sfsholden added a commit that referenced this pull request Aug 13, 2020
* Add slack integration and change publish process

* Update default publish-type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants