-
Notifications
You must be signed in to change notification settings - Fork 125
Add Slack Integration and Update Publish Process (@W-7953925) #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
color: '#0E1111' | ||
- node-latest | ||
- node-12 | ||
- node-10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the cache job needed here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 4 jobs restore the cache for themselves already I believe - is that what you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm referring to this piece here. I don't think it's needed, but wanted to pose the question just in case:
- cache:
filters:
tags:
only: /^v.*/
branches:
ignore: /.*/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's needed, at least not with that specific config
@@ -4,6 +4,15 @@ version: 2.1 | |||
orbs: | |||
win: circleci/windows@2.2.0 | |||
sfchangecase: salesforce/change-case-management@3 | |||
slack: circleci/slack@3.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference - there's additional setup that has to take place for the slack integration. This is the guide I am following.
Section:
To get started with enabling notifications in Slack for a specific project, head to the Settings page for your project. Click on Slack Integration in the sidebar and follow the steps to setup Slack.
@lcampos It looks like we need to change the required status from the CircleCi workflow from 'deploy-and-retrieve' to 'commit-workflow'. I don't believe I have the appropriate access to change it. |
* Add slack integration and change publish process * Update default publish-type
* Add slack integration and change publish process * Update default publish-type
What does this PR do?
What issues does this PR fix or reference?
@W-7953925@