Skip to content

Fix NetworkBranding content file not being included in conversion #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

brpowell
Copy link
Contributor

@brpowell brpowell commented Aug 8, 2020

What does this PR do?

A NetworkBranding component's content file was not included in a conversion. It's because the registry incorrectly resolved the component on account of the type not having the right adapter assigned to it.

What issues does this PR fix or reference?

@W-7931660@

Resolved Component Before (missing content property)

SourceComponent {
    name: 'cbE_Bikes',
    type:
     { id: 'networkbranding',
       name: 'NetworkBranding',
       suffix: 'networkBranding',
       directoryName: 'networkBranding',
       inFolder: false },
    xml:
     '/Users/b.powell/dev/dx-projects/ebikes-lwc/force-app/main/default/networkBranding/cbE_Bikes.networkBranding-meta.xml',
    parent: undefined,
    _tree: NodeFSTreeContainer {},
    forceIgnore:
     ForceIgnore {
       parser: [Ignore],
       forceIgnoreDirectory: '/Users/b.powell/dev/dx-projects/ebikes-lwc' } }

Resolved Component After (content property set)

SourceComponent {
    name: 'cbE_Bikes',
    type:
     { id: 'networkbranding',
       name: 'NetworkBranding',
       suffix: 'networkBranding',
       directoryName: 'networkBranding',
       inFolder: false },
    xml:
     '/Users/b.powell/dev/dx-projects/ebikes-lwc/force-app/main/default/networkBranding/cbE_Bikes.networkBranding-meta.xml',
    parent: undefined,
    content:
     '/Users/b.powell/dev/dx-projects/ebikes-lwc/force-app/main/default/networkBranding/cbE_Bikes.networkBranding',
    _tree: NodeFSTreeContainer {},
    forceIgnore:
     ForceIgnore {
       parser: [Ignore],
       forceIgnoreDirectory: '/Users/b.powell/dev/dx-projects/ebikes-lwc' } }

@brpowell brpowell requested a review from a team as a code owner August 8, 2020 00:04
@brpowell brpowell requested a review from shetzel August 8, 2020 00:04
Copy link
Contributor

@shetzel shetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brpowell brpowell merged commit 60f19a7 into develop Aug 10, 2020
@brpowell brpowell deleted the bp/networkBrandingAdapter branch August 10, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants