feat(specs,tests): Implement EIP-7928 Block-Level Access Lists #1719

fselmo · 2025-10-31T02:47:35Z

🗒️ Description

Implement EIP-7928: Block-Level Access Lists

🔗 Related Issues or PRs

Ported from fselmo/execution-specs branch

✅ Checklist

All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
```
uvx tox -e static
```
All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
All: Considered adding an entry to CHANGELOG.md.
All: Considered updating the online docs in the ./docs/ directory.
All: Set appropriate labels for the changes (only maintainers can apply labels).
Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

codecov-commenter · 2025-11-11T21:20:35Z

Codecov Report

❌ Patch coverage is 79.05660% with 111 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.07%. Comparing base (5eb4e7b) to head (5e6fe05).
⚠️ Report is 70 commits behind head on forks/amsterdam.

Files with missing lines	Patch %	Lines
src/ethereum/forks/amsterdam/state_tracker.py	66.66%	45 Missing and 1 partial ⚠️
...reum/forks/amsterdam/block_access_lists/builder.py	62.26%	37 Missing and 3 partials ⚠️
src/ethereum/forks/amsterdam/fork.py	78.04%	7 Missing and 2 partials ⚠️
...um/forks/amsterdam/block_access_lists/rlp_utils.py	60.00%	8 Missing ⚠️
...ethereum/forks/amsterdam/vm/instructions/system.py	94.64%	3 Missing and 3 partials ⚠️
src/ethereum/genesis.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           forks/amsterdam    #1719      +/-   ##
===================================================
- Coverage            86.33%   86.07%   -0.27%     
===================================================
  Files                  538      599      +61     
  Lines                34557    39527    +4970     
  Branches              3222     3780     +558     
===================================================
+ Hits                 29835    34021    +4186     
- Misses                4148     4872     +724     
- Partials               574      634      +60

Flag	Coverage Δ
unittests	`86.07% <79.05%> (-0.27%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

spencer-tb

Wanted to jump in on a review here. Thanks for pushing on with this. LGTM overall.
Just some questions and small comments!

...ting/src/execution_testing/cli/pytest_commands/plugins/consume/simulators/helpers/ruleset.py

packages/testing/src/execution_testing/test_types/block_access_list/modifiers.py

src/ethereum/forks/amsterdam/state_tracker.py

packages/testing/src/execution_testing/test_types/block_access_list/modifiers.py

tests/amsterdam/eip7928_block_level_access_lists/test_cases.md

src/ethereum/forks/amsterdam/fork.py

Bonus: - fix(test): remove unnecessary isolation for enginex

… space)

…rison - This will also help with support for any forks of this repo for L2s or other projects if some fork definitions don't have any meaningful relationship to SpuriousDragon.

…nit tests

* tests(eip-7928): remove bal from block body * fix(tests): clean up json_infra and genesis bal in block * fix(tests): fix add_genesis_block empty bal hash --------- Co-authored-by: fselmo <fselmo2@gmail.com>

danceratopz

Amazing collaboration by all participants on this PR!

By no means a full review, just two random minor comments! 😄 Perhaps we could address the docstring in this PR. The complexity comment is more of an observation, respectively, a genuine question out of curiosity 🙂

src/ethereum/forks/amsterdam/blocks.py

src/ethereum/forks/amsterdam/block_access_lists/rlp_utils.py

- Add CHANGELOG entry

* tests(eip-7928): generalize eip-7934 tests * ci(eip-7928): run all amsterdam tests on py3 and pypy3 --------- Co-authored-by: fselmo <fselmo2@gmail.com>

- Add CHANGELOG entry

fselmo changed the title ~~Eips/amsterdam/eip 7928~~ feat(specs,tests): Implement EIP-7928 Block-Level Access Lists Oct 31, 2025

fselmo force-pushed the eips/amsterdam/eip-7928 branch from 96afd82 to 5548642 Compare October 31, 2025 02:49

This was referenced Oct 31, 2025

✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access fselmo/execution-specs#23

Closed

feat: Block-Level Access List support for Amsterdam #1381

Closed

fselmo force-pushed the forks/amsterdam branch from 1f23a42 to a0cdc21 Compare November 4, 2025 21:49

fselmo force-pushed the eips/amsterdam/eip-7928 branch from 70a7786 to be41913 Compare November 4, 2025 21:55

fselmo force-pushed the forks/amsterdam branch from a0cdc21 to 28a68cd Compare November 4, 2025 22:26

fselmo force-pushed the eips/amsterdam/eip-7928 branch from be41913 to 20db73a Compare November 4, 2025 22:28

fselmo force-pushed the forks/amsterdam branch from 28a68cd to cb3daac Compare November 11, 2025 15:11

fselmo force-pushed the eips/amsterdam/eip-7928 branch 2 times, most recently from 4388bef to 0395133 Compare November 11, 2025 15:35

fselmo force-pushed the forks/amsterdam branch from cb3daac to dfeccbd Compare November 17, 2025 19:14

fselmo force-pushed the eips/amsterdam/eip-7928 branch from 44cb92a to e755ca3 Compare November 17, 2025 19:29

fselmo force-pushed the eips/amsterdam/eip-7928 branch 3 times, most recently from 820ee4d to b72a0da Compare November 25, 2025 21:48

fselmo force-pushed the forks/amsterdam branch from dfeccbd to e597ce3 Compare December 8, 2025 22:23

fselmo force-pushed the eips/amsterdam/eip-7928 branch 2 times, most recently from ebc749e to 6044b67 Compare December 9, 2025 01:58

fselmo force-pushed the forks/amsterdam branch from 3d2eede to 9e161b6 Compare December 15, 2025 19:10

fselmo force-pushed the eips/amsterdam/eip-7928 branch 2 times, most recently from be73122 to ba0eec1 Compare December 17, 2025 22:12

fselmo force-pushed the eips/amsterdam/eip-7928 branch from f8f52d9 to d7d6136 Compare January 12, 2026 20:12

fselmo marked this pull request as ready for review January 12, 2026 20:12

fselmo force-pushed the eips/amsterdam/eip-7928 branch from d7d6136 to 41a5637 Compare January 12, 2026 23:26

danceratopz mentioned this pull request Jan 13, 2026

STEEL Weekly Meeting, Wed 14th Jan ethsteel/pm#37

Closed

spencer-tb mentioned this pull request Jan 15, 2026

chore(hive): update workflow to run new bal tests ethpandaops/bal-devnets#22

Merged

spencer-tb approved these changes Jan 15, 2026

View reviewed changes

fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 15, 2026

chore: clean up based on comments on PR ethereum#1719

ea1fbd8

fselmo and others added 11 commits January 15, 2026 16:04

refactor(test): Tangerine -> TangerineWhistle; comments on PR #1954

c7c72be

Bonus: - fix(test): remove unnecessary isolation for enginex

fix(tool): Fix EvmOneTransitionTool parsing for TangerineWhistle (add…

4feb7ec

… space)

feat(test): Extend selfdestruct tests to all Amsterdam gas boundaries

aa2d744

refactor(test): fork.supports_protected_txs() instead of direct compa…

b185b58

…rison - This will also help with support for any forks of this repo for L2s or other projects if some fork definitions don't have any meaningful relationship to SpuriousDragon.

refactor: address comments from PR #1954

3aea2ff

feat(test): Add selfdestruct to system contracts + to self from initcode

24be6c7

feat(test-commands): Allow pytest valid fork markers as params; add u…

c229b1e

…nit tests

refactor(spec): Remove check_gas where unnecessary for instructions

7afb7c0

fix(test-fill): organize alloc groups by pytest param (enginex)

b67dadd

fix(tests): remove bal from block body (#2017)

1c2f23b

* tests(eip-7928): remove bal from block body * fix(tests): clean up json_infra and genesis bal in block * fix(tests): fix add_genesis_block empty bal hash --------- Co-authored-by: fselmo <fselmo2@gmail.com>

feat(spec-tests): Update json_infra tests version (#1939)

2da45fe

fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 15, 2026

chore: clean up based on comments on PR ethereum#1719

b6f99bb

fselmo force-pushed the eips/amsterdam/eip-7928 branch from ea1fbd8 to b6f99bb Compare January 15, 2026 23:17

fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 15, 2026

chore: clean up based on comments on PR ethereum#1719

f3e3528

fselmo force-pushed the eips/amsterdam/eip-7928 branch from b6f99bb to f3e3528 Compare January 15, 2026 23:19

spencer-tb added A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-feat Category: an improvement or new feature P-urgent A-test-tests Area: tests for packages/testing labels Jan 16, 2026

danceratopz approved these changes Jan 16, 2026

View reviewed changes

src/ethereum/forks/amsterdam/blocks.py Outdated Show resolved Hide resolved

src/ethereum/forks/amsterdam/block_access_lists/rlp_utils.py Outdated Show resolved Hide resolved

fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 16, 2026

chore: clean up based on comments on PR ethereum#1719

9fd8770

fselmo force-pushed the eips/amsterdam/eip-7928 branch from f3e3528 to 9fd8770 Compare January 16, 2026 16:28

fselmo added a commit that referenced this pull request Jan 16, 2026

chore: clean up based on comments on PR #1719

5b30479

fselmo force-pushed the eips/amsterdam/eip-7928 branch from bdf11ea to 018819d Compare January 16, 2026 17:06

fselmo and others added 2 commits January 16, 2026 10:23

chore: clean up based on comments on PR #1719

232a965

- Add CHANGELOG entry

tests(eip-7928): generalize eip-7934 tests (#2022)

5e6fe05

* tests(eip-7928): generalize eip-7934 tests * ci(eip-7928): run all amsterdam tests on py3 and pypy3 --------- Co-authored-by: fselmo <fselmo2@gmail.com>

fselmo force-pushed the eips/amsterdam/eip-7928 branch from 018819d to 5e6fe05 Compare January 16, 2026 17:23

fselmo merged commit 1d11d8d into forks/amsterdam Jan 16, 2026
18 of 20 checks passed

fselmo added a commit that referenced this pull request Jan 16, 2026

chore: clean up based on comments on PR #1719

0313063

- Add CHANGELOG entry

spencer-tb mentioned this pull request Jan 19, 2026

chore(ci): until amsterdam #1923

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(specs,tests): Implement EIP-7928 Block-Level Access Lists #1719

feat(specs,tests): Implement EIP-7928 Block-Level Access Lists #1719

Uh oh!

fselmo commented Oct 31, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Nov 11, 2025 •

edited by codecov bot

Loading

Uh oh!

spencer-tb left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danceratopz left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

feat(specs,tests): Implement EIP-7928 Block-Level Access Lists #1719

feat(specs,tests): Implement EIP-7928 Block-Level Access Lists #1719

Uh oh!

Conversation

fselmo commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗒️ Description

🔗 Related Issues or PRs

✅ Checklist

Cute Animal Picture

Uh oh!

codecov-commenter commented Nov 11, 2025 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

spencer-tb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danceratopz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

fselmo commented Oct 31, 2025 •

edited

Loading

codecov-commenter commented Nov 11, 2025 •

edited by codecov bot

Loading