tests(eip-7928): remove bal from block body #2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
merged commit c755b2c
into
ethereum:eips/amsterdam/eip-7928
15 of 17 checks passed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7928 #2017 +/- ##
========================================================
Coverage 86.32% 86.33%
========================================================
Files 538 538
Lines 34561 34559 -2
Branches 3224 3223 -1
========================================================
Hits 29835 29835
+ Misses 4152 4150 -2
Partials 574 574
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fselmo
added a commit
to fselmo/execution-specs
that referenced
this pull request
Jan 15, 2026
* tests(eip-7928): remove bal from block body * fix(tests): clean up json_infra and genesis bal in block * fix(tests): fix add_genesis_block empty bal hash --------- Co-authored-by: fselmo <fselmo2@gmail.com>
fselmo
added a commit
to fselmo/execution-specs
that referenced
this pull request
Jan 15, 2026
* tests(eip-7928): remove bal from block body * fix(tests): clean up json_infra and genesis bal in block * fix(tests): fix add_genesis_block empty bal hash --------- Co-authored-by: fselmo <fselmo2@gmail.com>
fselmo
added a commit
that referenced
this pull request
Jan 16, 2026
* tests(eip-7928): remove bal from block body * fix(tests): clean up json_infra and genesis bal in block * fix(tests): fix add_genesis_block empty bal hash --------- Co-authored-by: fselmo <fselmo2@gmail.com>
jsign
pushed a commit
to jsign/execution-specs
that referenced
this pull request
Jan 20, 2026
…compiles/vectors/secp256r1_test.json (ethereum#2017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
In EIP-7928, the BAL is not expected to be a part of the block body. Although this change was implemented on the specs side, the testing famework still includes the BAL while computing the block RLP
🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.