✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access #23

raxhvl · 2025-10-29T08:56:01Z

Adds new EIP-7928 test cases for Coinbase, withdrawal, edge cases for storage and account access.

Tests

Coinbase

test_bal_empty_block_no_coinbase
test_bal_coinbase_zero_tip

EIP-4895 Withdrawal

test_bal_withdrawal_empty_block
test_bal_withdrawal_and_transaction
test_bal_withdrawal_to_nonexistent_account
test_bal_withdrawal_no_evm_execution
test_bal_withdrawal_and_state_access_same_account
test_bal_withdrawal_and_value_transfer_same_address
test_bal_multiple_withdrawals_same_address
test_bal_withdrawal_and_selfdestruct
test_bal_withdrawal_and_new_contract
test_bal_zero_withdrawal
test_bal_withdrawal_to_precompiles
test_bal_withdrawal_largest_amount
test_bal_withdrawal_to_coinbase
test_bal_withdrawal_to_coinbase_empty_block

Precompiles

test_bal_precompile_funded
test_bal_precompile_call

Non-existent accounts

test_bal_nonexistent_value_transfer
test_bal_nonexistent_account_access

Storage edge cases

test_bal_storage_write_read_same_frame
test_bal_storage_write_read_cross_frame

Blockers

cr-gpt · 2025-10-29T08:56:04Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2025-10-29T21:50:02Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2025-10-29T21:53:25Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2025-10-29T21:56:56Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

tests/amsterdam/eip7928_block_level_access_lists/test_cases.md

fselmo

@raxhvl I added some fixes to this but this has everything passing after #29 gets in. I will wait for that and then we can merge this. Thanks for all the work here! 👍🏼

fselmo · 2025-10-30T13:22:37Z

@raxhvl can you fix the static lint issues here?

raxhvl · 2025-10-30T15:01:54Z

Hey @fselmo fixed the static issue, I have few more new tests since your review:

❇️

Withdrawal

test_bal_withdrawal_to_precompiles
test_bal_withdrawal_largest_amount
test_bal_withdrawal_to_coinbase
test_bal_withdrawal_to_coinbase_empty_block

Precompiles

test_bal_precompile_funded
test_bal_precompile_call

Non-existent accounts

test_bal_nonexistent_value_transfer
test_bal_nonexistent_account_access

Storage edge cases

test_bal_storage_write_read_same_frame
test_bal_storage_write_read_cross_frame

I'm done adding tests now - Once all issues are closed feel free to merge the tests if everything passes. Could you also carefully review the coinbase once before merging? Thanks!

- `self.txs.successfully_parsed` is a list of transaction indexes, not transactions. The "if tx" check here would then check `if 0` which parses as a boolean ``False``. This means we would skip counting the tx if index=0 was successful. - Fixes some test expectations where `post_code` was being checked instead of ``new_code``.

fselmo · 2025-10-30T22:34:58Z

@raxhvl this looks good to me now. I fixed the issues with the precompile tests here (the tests were wrong, not the specs) and I split the test that was using pytest.skip because I don't think we should have this built into tests. Please make sure this looks good to you here and if so I'm good to merge this so we can move this feature branch over to ethereum/execution-specs as branch eips/amsterdam/eip-7928 so we can start to release from there. The reason for this is we need the feature branch to be part of ethereum/execution-specs rather than my fork (fselmo/execution-specs).

raxhvl · 2025-10-31T02:47:03Z

Hey @fselmo - The changes look good to me, all tests are now passing, you can merge this 👍

fselmo · 2025-10-31T02:50:41Z

@raxhvl I've created the branch to execution-specs here with these changes in there! Going to close this as we're all caught up there now.

* chore: add grammar check automation files * docs: fix grammar in consume plugin files (#20) Fix grammar issues in consume plugin docstrings and comments: - "A dictionary caches" -> "A dictionary that caches" (missing "that") - "Definers" -> "Defines" (typo) - "Un-expected" -> "Unexpected" (incorrect hyphenation) - "older version" -> "older versions" (subject-verb agreement) Co-authored-by: Claude <noreply@anthropic.com> * chore(docs): fix grammar in filler plugin docstrings (#21) - Fix subject-verb agreement: "The forks is" -> "The fork is" - Fix preposition: "value to each" -> "value for each" - Fix sentence structure: "(which) ... occurs" -> ", which ... that occurs" Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in execute plugin files (#22) - Fix "using in live networks" -> "on live networks" (execute.py:2) - Fix missing spaces between concatenated help strings in execute.py - Fix "using for test filling" -> "used for test filling" (pre_alloc.py:1) - Fix missing spaces in concatenated help strings in remote.py Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in forks, shared, and help plugin files (#23) Fixed 9 grammar issues: - forks/__init__.py: Added missing "and" in docstring - forks/forks.py: Fixed "ran" -> "run" (passive voice) - forks/forks.py: Removed space in URL fragment - forks/forks.py: Fixed double "any any" -> "any" - test_bad_command_line_options.py: Fixed article/noun agreement - test_bad_validity_markers.py: Fixed article/noun agreement - shared/helpers.py: Fixed verb tense for parallel structure - shared/execute_fill.py: Added missing article "A" - help/help.py: Fixed double article "the a" -> "a" Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in pytest_commands/plugins root files (#24) Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in cli/pytest_commands root files (#25) Remove extra space after newline in watcher.py watch mode message. Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in cli/gentest and cli/fuzzer_bridge (#26) - Fix article "An provider" → "A provider" (test_context_providers.py) - Fix subject-verb agreement "generates" → "generate" (test_providers.py) - Add missing preposition "for" in "A request manager for Ethereum RPC calls" (request_manager.py) Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in cli/eest, cli/input, and cli/fillerconvert (#27) * docs: fix grammar in cli/eest, cli/input, and cli/fillerconvert Fix missing space in string concatenation in quotes.py where "that" and "experience" were joined without a space. Flag one low-confidence issue in verify_filled.py for manual review regarding informal verb usage. * docs: apply manual grammar fix in verify_filled.py Improve docstring clarity by: - Adding missing articles ("the original", "the refilled test") - Replacing informal "Regex" verb with "Extract" - Reformatting for better readability --------- Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in packages/testing/src/execution_testing/cli/*.py (#28) - gen_index.py: Add missing space between sentences in help text - modify_static_test_gas_limits.py: Remove duplicate word "files files" - tox_helpers.py: Remove extra space in error message - show_pre_alloc_group_stats.py: Fix capitalization mid-sentence Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in packages/testing/src/execution_testing/cli/tests (#29) - Fix "allows to actually fill" → "allows actually filling" (missing verb form) - Fix "uses the a temporary" → "uses a temporary" (double article) Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in test_types module (#30) - Fix double space in helpers.py docstring - Complete incomplete sentence in trie.py module docstring Co-authored-by: Claude <noreply@anthropic.com> * docs: grammar check specs module (round 12) (#31) Reviewed 28 files in packages/testing/src/execution_testing/specs/**/*.py for grammar issues. Fixed 1 grammar issue: - blockchain.py:167-168 - fixed sentence fragment "encoding. included" Co-authored-by: Claude <noreply@anthropic.com> * docs: grammar check round 13 (fixtures + client_clis) (#32) Reviewed packages/testing/src/execution_testing/fixtures/**/*.py (16 files) - No grammar issues found Reviewed packages/testing/src/execution_testing/client_clis/**/*.py (20 files) Fixed 4 grammar issues: - ethereum_cli.py:158 - Added missing space after "0!" - evmone.py:207 - "an select" -> "and select" - nethermind.py:209 - "an select" -> "and select" - geth.py:383 - "an select" -> "and select" Flagged 1 item for manual review: - clis/__init__.py:1 - "CL interfaces" may be typo for "CLI interfaces" Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in base_types module (#33) - Fix "it can added" -> "it can be added" in mixins.py - Fix "and returns" -> "and return" for consistent imperative form in composite_types.py - Fix "an hexadecimal numbers" -> "hexadecimal numbers" in base_types.py Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in forks module (ethereum#34) base_fork.py: - precompiles(): "Return list precompiles" -> "Return list of precompiles" - system_contracts(): "Return list system-contracts" -> "Return list of system contracts" forks/forks/forks.py: - Standardize "pre-compiles" -> "precompiles" (no hyphen) in: - Frontier.precompiles() - Homestead.precompiles() - Byzantium.precompiles() - Istanbul.precompiles() - Cancun.precompiles() - Prague.precompiles() - Osaka.precompiles() - Standardize "system-contracts" -> "system contracts" in Frontier.system_contracts() - Fix subject-verb agreement: "pre-compile for BLS operations are" -> "precompiles for BLS operations are" - Fix max_initcode_size(): merge standalone string into docstring with proper formatting - Add missing article "a" before "precompile for" in Istanbul, Cancun, and Osaka Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in tools and exceptions modules (ethereum#35) Fix typos and grammar issues: - Fix "defniitions" -> "definitions" in engine_api.py - Fix "it's" -> "its" (possessive) in eof.py and exceptions.py - Fix "an stack" -> "a stack" for underflow/overflow in eof.py and exceptions.py Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in vm, rpc, and config modules (ethereum#36) Remove duplicate text in error message in opcodes.py Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in execution_testing core modules (logging, execution, checklists, benchmark) and root files (ethereum#37) Fixed "were request" -> "were requested" in blob_transaction.py comment. Co-authored-by: Claude <noreply@anthropic.com> * docs: fix docstring in client_clis module Corrected terminology from "CL interfaces" to "EL clients" - these are Execution Layer client implementations, not Consensus Layer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: fix grammar in exceptions module - block.py: "is calculated incorrect" → "is calculated incorrectly" - transaction.py: "is exceeds" → "exceeds" (removed double verb) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: fix punctuation in checklists module Changed period to colon in DataPortionVariables docstring to properly introduce the list of test cases (Top, Bottom, Middle). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: remove files used for llm automation --------- Co-authored-by: Claude <noreply@anthropic.com>

raxhvl changed the title ~~✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access~~ feat(tests): ✨ EIP-7928 tests for coinbase, withdrawal, storage, and account access Oct 29, 2025

raxhvl changed the title ~~feat(tests): ✨ EIP-7928 tests for coinbase, withdrawal, storage, and account access~~ ✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access Oct 29, 2025

raxhvl force-pushed the feat/bal-tests branch from 20e6239 to 2534878 Compare October 29, 2025 09:38

Repository owner deleted a comment from cr-gpt bot Oct 29, 2025

nerolation mentioned this pull request Oct 29, 2025

fix withdrawal bal index tracking #28

Closed

fselmo force-pushed the feat/bal-tests branch from 434a46d to d216517 Compare October 29, 2025 21:53

fselmo force-pushed the feat/bal-tests branch from d216517 to 2617d30 Compare October 29, 2025 21:56

fselmo mentioned this pull request Oct 29, 2025

fix(specs): Fix zero value withdrawals BAL tracking #29

Merged

fselmo reviewed Oct 29, 2025

View reviewed changes

tests/amsterdam/eip7928_block_level_access_lists/test_cases.md Show resolved Hide resolved

fselmo approved these changes Oct 29, 2025

View reviewed changes

raxhvl added 12 commits October 30, 2025 14:28

feat(tests): EIP-7928 coinbase

04929a2

feat(tests): EIP-7928 test_bal_withdrawal_empty_block

fd48a98

feat(tests): EIP-7928 test_bal_withdrawal_with_transaction

dcfc47a

feat(tests): EIP-7928 test_bal_withdrawal_empty_block

56f9ed0

feat(tests): EIP-7928 test_bal_withdrawal_to_nonexistent_account

96b5ba3

feat(tests): EIP-7928 test_bal_withdrawal_no_evm_execution

04ce1d9

feat(tests): EIP-7928 withdrawal_and_state_access_same_account

17e037f

feat(tests): EIP-7928 withdrawal_and_value_transfer_same_address

d858f7d

feat(tests): EIP-7928 test_bal_multiple_withdrawals_same_address

347da4b

feat(tests): EIP-7928 test_bal_withdrawal_and_selfdestruct

8908c4c

feat(tests): EIP-7928 test_bal_withdrawal_and_new_contract

2f35c5c

feat(tests): EIP-7928 test_bal_zero_withdrawal

2d3d38f

fselmo and others added 12 commits October 30, 2025 14:28

fix(tests): expectation for nonexistent account in post

f2813aa

feat(tests): EIP-7928 test_bal_withdrawal_to_precompiles

18f294c

feat(tests): EIP-7928 test_bal_withdrawal_largest_amount

5822ea3

feat(tests): EIP-7928 test_bal_withdrawal_to_coinbase

61450b5

feat(tests): EIP-7928 test_bal_withdrawal_to_coinbase_empty_block

b3dd4d6

feat(tests): EIP-7928 test_bal_precompiles

d25d612

feat(tests): EIP-7928 test_bal_nonexistent_value_transfer

ddb7db4

feat(tests): EIP-7928 test_bal_nonexistent_account_access

bf9f2c7

feat(tests): EIP-7928 test_bal_storage_write_read_same_frame

70aebee

feat(tests): EIP-7928 test_bal_storage_write_read_cross_frame

c8f660b

chore(tests): linting fixes

ee14d6c

fselmo force-pushed the feat/bal-tests branch from 2cc9f2c to ee14d6c Compare October 30, 2025 20:29

fselmo added 2 commits October 30, 2025 15:58

fix(tests): Use valid inputs to precompile tests

7c0a150

refactor(tests): Prevent skips by splitting tests appropriately

4906eda

fselmo closed this Oct 31, 2025

nerolation mentioned this pull request Oct 31, 2025

EIP-7928 Breakout #6, Nov 5, 2025 ethereum/pm#1787

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access #23

✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access #23

Uh oh!

raxhvl commented Oct 29, 2025 •

edited

Loading

Uh oh!

cr-gpt bot commented Oct 29, 2025

Uh oh!

cr-gpt bot commented Oct 29, 2025

Uh oh!

cr-gpt bot commented Oct 29, 2025

Uh oh!

cr-gpt bot commented Oct 29, 2025

Uh oh!

Uh oh!

fselmo left a comment

Uh oh!

fselmo commented Oct 30, 2025

Uh oh!

raxhvl commented Oct 30, 2025

Uh oh!

fselmo commented Oct 30, 2025 •

edited

Loading

Uh oh!

raxhvl commented Oct 31, 2025

Uh oh!

fselmo commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access #23

✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access #23

Uh oh!

Conversation

raxhvl commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests

Coinbase

EIP-4895 Withdrawal

Precompiles

Non-existent accounts

Storage edge cases

Blockers

Uh oh!

cr-gpt bot commented Oct 29, 2025

Uh oh!

cr-gpt bot commented Oct 29, 2025

Uh oh!

cr-gpt bot commented Oct 29, 2025

Uh oh!

cr-gpt bot commented Oct 29, 2025

Uh oh!

Uh oh!

fselmo left a comment

Choose a reason for hiding this comment

Uh oh!

fselmo commented Oct 30, 2025

Uh oh!

raxhvl commented Oct 30, 2025

Withdrawal

Precompiles

Non-existent accounts

Storage edge cases

Uh oh!

fselmo commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raxhvl commented Oct 31, 2025

Uh oh!

fselmo commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

raxhvl commented Oct 29, 2025 •

edited

Loading

fselmo commented Oct 30, 2025 •

edited

Loading