Move evm.message_is_static check to top of function #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
fselmo
force-pushed
the
feat/amsterdam-fork-and-block-access-lists
branch
from
c53b609 to
e34ee25
Compare
fselmo
force-pushed
the
move-static-call
branch
from
fdb2b77 to
5fd8c62
Compare
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Owner
|
Hey @nerolation. We had some huge changes to the |
Collaborator
Author
|
Only this PR? Yeah looks good! |
fselmo
force-pushed
the
feat/amsterdam-fork-and-block-access-lists
branch
from
e34ee25 to
9aeac17
Compare
Collaborator
Author
|
Ah, didn't see the all the changes. |
fselmo
force-pushed
the
feat/amsterdam-fork-and-block-access-lists
branch
from
9aeac17 to
5898499
Compare
fselmo
force-pushed
the
move-static-call
branch
from
5fd8c62 to
a65b2e8
Compare
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Owner
|
Ok sorry. Should be good now. We have a new commit message check (lint-commits) that will check for |
Owner
|
For ease of rebasing, I squashed all of our many BAL updates as if it was the first implementation commit. I hope this is OK. I can try to separate it more if you think that would be better. I do hope this is the last big refactor we have to rebase on top of 😓. So we can keep a cleaner history if we want from here on out. Let me know your thoughts. |
Owner
|
There is also a different case for this check that was brought up here: https://discord.com/channels/595666850260713488/1432349632616337520/1432412576704233703 We should investigate this and add it in this PR. What do you think? |
Collaborator
Author
|
yeah agree, will put it into this pr |
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Owner
|
@nerolation are we still including these changes? Do you know what the status is here? 🤔 |
Collaborator
Author
|
Yeah I think so, but let's double-check on discord |
fselmo
force-pushed
the
move-static-call
branch
from
d0ca100 to
0f2a605
Compare
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
fselmo
approved these changes
Oct 29, 2025
Owner
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
LGTM, pending clarification here: https://discord.com/channels/595666850260713488/1432349632616337520/1433224296179699844
fselmo
merged commit 72babab
into
fselmo:feat/amsterdam-fork-and-block-access-lists
4 of 10 checks passed
fselmo
pushed a commit
that referenced
this pull request
Oct 31, 2025
3 tasks
fselmo
pushed a commit
that referenced
this pull request
Nov 4, 2025
fselmo
pushed a commit
that referenced
this pull request
Nov 4, 2025
fselmo
pushed a commit
that referenced
this pull request
Nov 11, 2025
fselmo
pushed a commit
that referenced
this pull request
Nov 11, 2025
fselmo
pushed a commit
that referenced
this pull request
Nov 17, 2025
fselmo
pushed a commit
that referenced
this pull request
Dec 9, 2025
fselmo
pushed a commit
that referenced
this pull request
Dec 9, 2025
fselmo
pushed a commit
that referenced
this pull request
Dec 15, 2025
fselmo
pushed a commit
that referenced
this pull request
Dec 17, 2025
fselmo
pushed a commit
that referenced
this pull request
Jan 6, 2026
* chore: add grammar check automation files * docs: fix grammar in consume plugin files (#20) Fix grammar issues in consume plugin docstrings and comments: - "A dictionary caches" -> "A dictionary that caches" (missing "that") - "Definers" -> "Defines" (typo) - "Un-expected" -> "Unexpected" (incorrect hyphenation) - "older version" -> "older versions" (subject-verb agreement) Co-authored-by: Claude <noreply@anthropic.com> * chore(docs): fix grammar in filler plugin docstrings (#21) - Fix subject-verb agreement: "The forks is" -> "The fork is" - Fix preposition: "value to each" -> "value for each" - Fix sentence structure: "(which) ... occurs" -> ", which ... that occurs" Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in execute plugin files (#22) - Fix "using in live networks" -> "on live networks" (execute.py:2) - Fix missing spaces between concatenated help strings in execute.py - Fix "using for test filling" -> "used for test filling" (pre_alloc.py:1) - Fix missing spaces in concatenated help strings in remote.py Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in forks, shared, and help plugin files (#23) Fixed 9 grammar issues: - forks/__init__.py: Added missing "and" in docstring - forks/forks.py: Fixed "ran" -> "run" (passive voice) - forks/forks.py: Removed space in URL fragment - forks/forks.py: Fixed double "any any" -> "any" - test_bad_command_line_options.py: Fixed article/noun agreement - test_bad_validity_markers.py: Fixed article/noun agreement - shared/helpers.py: Fixed verb tense for parallel structure - shared/execute_fill.py: Added missing article "A" - help/help.py: Fixed double article "the a" -> "a" Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in pytest_commands/plugins root files (#24) Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in cli/pytest_commands root files (#25) Remove extra space after newline in watcher.py watch mode message. Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in cli/gentest and cli/fuzzer_bridge (#26) - Fix article "An provider" → "A provider" (test_context_providers.py) - Fix subject-verb agreement "generates" → "generate" (test_providers.py) - Add missing preposition "for" in "A request manager for Ethereum RPC calls" (request_manager.py) Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in cli/eest, cli/input, and cli/fillerconvert (#27) * docs: fix grammar in cli/eest, cli/input, and cli/fillerconvert Fix missing space in string concatenation in quotes.py where "that" and "experience" were joined without a space. Flag one low-confidence issue in verify_filled.py for manual review regarding informal verb usage. * docs: apply manual grammar fix in verify_filled.py Improve docstring clarity by: - Adding missing articles ("the original", "the refilled test") - Replacing informal "Regex" verb with "Extract" - Reformatting for better readability --------- Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in packages/testing/src/execution_testing/cli/*.py (#28) - gen_index.py: Add missing space between sentences in help text - modify_static_test_gas_limits.py: Remove duplicate word "files files" - tox_helpers.py: Remove extra space in error message - show_pre_alloc_group_stats.py: Fix capitalization mid-sentence Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in packages/testing/src/execution_testing/cli/tests (#29) - Fix "allows to actually fill" → "allows actually filling" (missing verb form) - Fix "uses the a temporary" → "uses a temporary" (double article) Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in test_types module (#30) - Fix double space in helpers.py docstring - Complete incomplete sentence in trie.py module docstring Co-authored-by: Claude <noreply@anthropic.com> * docs: grammar check specs module (round 12) (#31) Reviewed 28 files in packages/testing/src/execution_testing/specs/**/*.py for grammar issues. Fixed 1 grammar issue: - blockchain.py:167-168 - fixed sentence fragment "encoding. included" Co-authored-by: Claude <noreply@anthropic.com> * docs: grammar check round 13 (fixtures + client_clis) (#32) Reviewed packages/testing/src/execution_testing/fixtures/**/*.py (16 files) - No grammar issues found Reviewed packages/testing/src/execution_testing/client_clis/**/*.py (20 files) Fixed 4 grammar issues: - ethereum_cli.py:158 - Added missing space after "0!" - evmone.py:207 - "an select" -> "and select" - nethermind.py:209 - "an select" -> "and select" - geth.py:383 - "an select" -> "and select" Flagged 1 item for manual review: - clis/__init__.py:1 - "CL interfaces" may be typo for "CLI interfaces" Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in base_types module (#33) - Fix "it can added" -> "it can be added" in mixins.py - Fix "and returns" -> "and return" for consistent imperative form in composite_types.py - Fix "an hexadecimal numbers" -> "hexadecimal numbers" in base_types.py Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in forks module (ethereum#34) base_fork.py: - precompiles(): "Return list precompiles" -> "Return list of precompiles" - system_contracts(): "Return list system-contracts" -> "Return list of system contracts" forks/forks/forks.py: - Standardize "pre-compiles" -> "precompiles" (no hyphen) in: - Frontier.precompiles() - Homestead.precompiles() - Byzantium.precompiles() - Istanbul.precompiles() - Cancun.precompiles() - Prague.precompiles() - Osaka.precompiles() - Standardize "system-contracts" -> "system contracts" in Frontier.system_contracts() - Fix subject-verb agreement: "pre-compile for BLS operations are" -> "precompiles for BLS operations are" - Fix max_initcode_size(): merge standalone string into docstring with proper formatting - Add missing article "a" before "precompile for" in Istanbul, Cancun, and Osaka Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in tools and exceptions modules (ethereum#35) Fix typos and grammar issues: - Fix "defniitions" -> "definitions" in engine_api.py - Fix "it's" -> "its" (possessive) in eof.py and exceptions.py - Fix "an stack" -> "a stack" for underflow/overflow in eof.py and exceptions.py Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in vm, rpc, and config modules (ethereum#36) Remove duplicate text in error message in opcodes.py Co-authored-by: Claude <noreply@anthropic.com> * docs: fix grammar in execution_testing core modules (logging, execution, checklists, benchmark) and root files (ethereum#37) Fixed "were request" -> "were requested" in blob_transaction.py comment. Co-authored-by: Claude <noreply@anthropic.com> * docs: fix docstring in client_clis module Corrected terminology from "CL interfaces" to "EL clients" - these are Execution Layer client implementations, not Consensus Layer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: fix grammar in exceptions module - block.py: "is calculated incorrect" → "is calculated incorrectly" - transaction.py: "is exceeds" → "exceeds" (removed double verb) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: fix punctuation in checklists module Changed period to colon in DataPortionVariables docstring to properly introduce the list of test cases (Top, Bottom, Middle). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: remove files used for llm automation --------- Co-authored-by: Claude <noreply@anthropic.com>
fselmo
pushed a commit
that referenced
this pull request
Jan 12, 2026
fselmo
pushed a commit
that referenced
this pull request
Jan 12, 2026
fselmo
pushed a commit
that referenced
this pull request
Jan 12, 2026
fselmo
pushed a commit
that referenced
this pull request
Jan 15, 2026
fselmo
pushed a commit
that referenced
this pull request
Jan 15, 2026
fselmo
pushed a commit
that referenced
this pull request
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the discussion here:
https://discord.com/channels/595666850260713488/1364000387195076608/1432349632616337520