tests(eip-7928): generalize eip-7934 tests #2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Updated the CI to run all amsterdam tests |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7928 #2022 +/- ##
==========================================================
Coverage ? 85.96%
==========================================================
Files ? 599
Lines ? 39575
Branches ? 3801
==========================================================
Hits ? 34021
Misses ? 4920
Partials ? 634
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
fselmo
reviewed
Jan 14, 2026
Contributor
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
This is a really nice solution for this π. Thanks for tacking it. I think we can simplify it even more by removing the gas_used from get_block_rlp_size() and from everywhere that calls it in that file but otherwise this lgtm ππΌ
gurukamath
force-pushed
the
generalize-7934-tests
branch
from
8d20f8e to
b3b576b
Compare
fselmo
approved these changes
Jan 15, 2026
Contributor
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
lgtm! Feel free to merge when CI passes ππΌ
fselmo
force-pushed
the
eips/amsterdam/eip-7928
branch
from
a3199dd to
ea1fbd8
Compare
8 tasks
fselmo
force-pushed
the
generalize-7934-tests
branch
6 times, most recently
from
de39b0d to
6338902
Compare
fselmo
force-pushed
the
eips/amsterdam/eip-7928
branch
from
ea1fbd8 to
b6f99bb
Compare
fselmo
force-pushed
the
eips/amsterdam/eip-7928
branch
from
b6f99bb to
f3e3528
Compare
fselmo
force-pushed
the
generalize-7934-tests
branch
6 times, most recently
from
c9da873 to
8ee14a9
Compare
gurukamath
force-pushed
the
generalize-7934-tests
branch
from
8ee14a9 to
acbcb4e
Compare
Contributor
Author
|
Updated to undo CI changes to |
fselmo
force-pushed
the
eips/amsterdam/eip-7928
branch
from
f3e3528 to
9fd8770
Compare
fselmo
merged commit bdf11ea
into
ethereum:eips/amsterdam/eip-7928
17 of 18 checks passed
fselmo
added a commit
that referenced
this pull request
Jan 16, 2026
* tests(eip-7928): generalize eip-7934 tests * ci(eip-7928): run all amsterdam tests on py3 and pypy3 --------- Co-authored-by: fselmo <fselmo2@gmail.com>
fselmo
added a commit
that referenced
this pull request
Jan 16, 2026
* tests(eip-7928): generalize eip-7934 tests * ci(eip-7928): run all amsterdam tests on py3 and pypy3 --------- Co-authored-by: fselmo <fselmo2@gmail.com>
fselmo
added a commit
that referenced
this pull request
Jan 16, 2026
* tests(eip-7928): generalize eip-7934 tests * ci(eip-7928): run all amsterdam tests on py3 and pypy3 --------- Co-authored-by: fselmo <fselmo2@gmail.com>
jsign
pushed a commit
to jsign/execution-specs
that referenced
this pull request
Jan 20, 2026
This was referenced Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ποΈ Description
Adding new fields to block header changes the block rlp size and teh current EIP-7934 tests do not handle this dynamically
π Related Issues or PRs
#1972
β Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture